You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/05 12:16:31 UTC
[GitHub] [tvm] echuraev opened a new issue #7981: Constants are stored two times with JSON Runtime
echuraev opened a new issue #7981:
URL: https://github.com/apache/tvm/issues/7981
Hello,
I faced the problem that the TVM export methods doesn’t strip original collection of constant tensor in case of usage external runtime like BNNS/ACL and others. First time we store constants in `GraphRuntimeFactory` when write it to the library and second time in `MetadataModule`. This leads to double size of final exported files and also increases memory footprint in runtime. In fact, it is enough to store constants only in `MetadataModule`, and we can strip the original constants. Maybe we could remove original constants from `GraphRuntimeFactory`and store them only in `MetadataModule`?
On the screenshot you can see that the weights were load two times in runtime:
This problem can be critical for different mobile devices with limited size of RAM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev commented on issue #7981: Constants are stored two times with JSON Runtime
Posted by GitBox <gi...@apache.org>.
echuraev commented on issue #7981:
URL: https://github.com/apache/tvm/issues/7981#issuecomment-832939184
Thank you! I'll check then the PR will be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on issue #7981: Constants are stored two times with JSON Runtime
Posted by GitBox <gi...@apache.org>.
comaniac commented on issue #7981:
URL: https://github.com/apache/tvm/issues/7981#issuecomment-832833798
https://github.com/apache/tvm/pull/7977 should solve this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev commented on issue #7981: Constants are stored two times with JSON Runtime
Posted by GitBox <gi...@apache.org>.
echuraev commented on issue #7981:
URL: https://github.com/apache/tvm/issues/7981#issuecomment-840996120
> ping @echuraev please close the PR if the problem is fixed
Yes, I remember about it. I'll do it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on issue #7981: Constants are stored two times with JSON Runtime
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #7981:
URL: https://github.com/apache/tvm/issues/7981#issuecomment-840880361
ping @echuraev please close the PR if the problem is fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev closed issue #7981: Constants are stored two times with JSON Runtime
Posted by GitBox <gi...@apache.org>.
echuraev closed issue #7981:
URL: https://github.com/apache/tvm/issues/7981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev commented on issue #7981: Constants are stored two times with JSON Runtime
Posted by GitBox <gi...@apache.org>.
echuraev commented on issue #7981:
URL: https://github.com/apache/tvm/issues/7981#issuecomment-842415920
It looks like the problem was fixed. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev commented on issue #7981: Constants are stored two times with JSON Runtime
Posted by GitBox <gi...@apache.org>.
echuraev commented on issue #7981:
URL: https://github.com/apache/tvm/issues/7981#issuecomment-842415920
It looks like the problem was fixed. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev closed issue #7981: Constants are stored two times with JSON Runtime
Posted by GitBox <gi...@apache.org>.
echuraev closed issue #7981:
URL: https://github.com/apache/tvm/issues/7981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org