You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/18 22:01:40 UTC
[GitHub] [spark] skambha commented on issue #27629: [SPARK-28067][SQL]Fix
incorrect results during aggregate sum for decimal overflow by throwing
exception
skambha commented on issue #27629: [SPARK-28067][SQL]Fix incorrect results during aggregate sum for decimal overflow by throwing exception
URL: https://github.com/apache/spark/pull/27629#issuecomment-587924941
Please see [my notes](https://issues.apache.org/jira/browse/SPARK-28067?focusedCommentId=17039403&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17039403) in this JIRA for the two approaches to fix this issue. This is a implementation for approach 1 fix. This is simple and straightforward compared to the approach2 PR.
I have another [pr 27627](https://github.com/apache/spark/pull/27627) that takes approach 2 to fix this issue. Both these will fix the incorrect results (which is good). Each have their pros and cons as listed in my comment in the JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org