You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/08 12:48:56 UTC

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19777: [hotfix][connector/pulsar][docs] Update atEventTime to atPublishTime in JavaDoc

MartijnVisser commented on code in PR #19777:
URL: https://github.com/apache/flink/pull/19777#discussion_r892316613


##########
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java:
##########
@@ -107,7 +107,7 @@
  *     .setSubscriptionName("flink-source-1")
  *     .setTopics(Arrays.asList(TOPIC1, TOPIC2))
  *     .setDeserializationSchema(PulsarDeserializationSchema.flinkSchema(new SimpleStringSchema()))
- *     .setUnboundedStopCursor(StopCursor.atEventTime(System.currentTimeMillis()))
+ *     .setUnboundedStopCursor(StopCursor.atPublishTime(System.currentTimeMillis()))

Review Comment:
   I'm not sure this is correct, especially since the explanation above says `For example the following PulsarSource stops after it consumes up to a event time when the Flink started.`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org