You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/05/13 07:39:19 UTC
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager
Reamer commented on code in PR #4355:
URL: https://github.com/apache/zeppelin/pull/4355#discussion_r872091416
##########
zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterLauncher.java:
##########
@@ -54,11 +57,11 @@ public InterpreterClient launchDirectly(InterpreterLaunchContext context) throws
StandardInterpreterLauncher interpreterLauncher = null;
if (isSpark()) {
- interpreterLauncher = new SparkInterpreterLauncher(zConf, recoveryStorage);
+ interpreterLauncher = (StandardInterpreterLauncher) pluginManager.createInterpreterLauncher("SparkInterpreterLauncher", recoveryStorage);
Review Comment:
I think it makes no difference, but I changed it.
##########
zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterLauncher.java:
##########
@@ -54,11 +57,11 @@ public InterpreterClient launchDirectly(InterpreterLaunchContext context) throws
StandardInterpreterLauncher interpreterLauncher = null;
if (isSpark()) {
- interpreterLauncher = new SparkInterpreterLauncher(zConf, recoveryStorage);
+ interpreterLauncher = (StandardInterpreterLauncher) pluginManager.createInterpreterLauncher("SparkInterpreterLauncher", recoveryStorage);
} else if (isFlink()) {
- interpreterLauncher = new FlinkInterpreterLauncher(zConf, recoveryStorage);
+ interpreterLauncher = (StandardInterpreterLauncher) pluginManager.createInterpreterLauncher("FlinkInterpreterLauncher", recoveryStorage);
Review Comment:
I think it makes no difference, but I changed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org