You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2017/06/01 12:32:50 UTC
Review Request 59713: LENS-1427: ExpressionResolver is removing
expressions if they are not answerable by *any* candidates
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59713/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1427
https://issues.apache.org/jira/browse/LENS-1427
Repository: lens
Description
-------
Should be at least one and *all*
Diffs
-----
checkstyle/pom.xml 2902c6b5846ccb12dd9e72a3617c504fa274d6ff
contrib/clients/pom.xml d7677a33c1ffd7e24478708246aef8fc4c4e127f
contrib/clients/python/pom.xml ac842bd17e2c456340649f5b227766b931dca102
contrib/pom.xml b36add0946fd536e9346e3aa009b2481ff03d96d
lens-api/pom.xml ece443034845685ea07268af3ee8aa7a6a01dec2
lens-cli/pom.xml 3640fdd70e25ee31a4d31ba54f3f5d3cc45c5855
lens-client/pom.xml 5b94800d16fc23287e6e1a0d96aff866219a8e7a
lens-cube/pom.xml deaeb3613dee4ad8cd2e54a1bbe7f6627f56cc8a
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89b3606383357f26cc4827069d0f7274158
lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336abe8ee372150ba76b3bd972b321fc9669
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 47bce655e97e7225cfa2943e0b07dad25ac8fcc9
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 7cad400bb12464c05b370a0aad5e7baec0248c1d
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 038d689ab39f5f41c5a813dfcd2ecb9eb6f2e2ec
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13811f85a625b3d41fc4fd42a5ec8bc300a
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 6c0d91adac61405ddcf23e3844c6205dbd6917b1
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13e270bff42beb6f6b9c3f2578e3ed71321
lens-cube/src/test/resources/schema/cubes/base/b1cube.xml e3e99098f4a8dbee06e29b2a7af265b14b702aab
lens-cube/src/test/resources/schema/cubes/base/b2cube.xml e5cf2c08959ffd1525b677e638f04944630e36dc
lens-cube/src/test/resources/schema/cubes/base/testcube.xml f123341f5ecb2c2124e2a14c5768f6d04f5766fa
lens-dist/pom.xml fb49931dcc607e82c4e0fd2f1ae90c46543d40b9
lens-dist/src/deb/control/postinst PRE-CREATION
lens-driver-es/pom.xml 925020e9209f7686097710c9c274b0f452b5b93c
lens-driver-hive/pom.xml 51205e9153c713083bc85ceadb27e78b40ed5d65
lens-driver-jdbc/pom.xml 5acd5d25785c6a2c28bc8bac0b848620455d4c27
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 75153f669d5b45accb7e0ae52e854a685de8cae1
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 8e042d1e52eebcdeb044a3394d58d93f22c3e34a
lens-driver-jdbc/src/test/resources/drivers/jdbc/jdbc1/jdbcdriver-site.xml ac5e43debbaa771d2723c29e24b3da980772c752
lens-examples/pom.xml af467eeb1a71b06214bf8188e44f5f63328a7858
lens-examples/src/main/resources/cube11.xml PRE-CREATION
lens-examples/src/main/resources/cube22.xml PRE-CREATION
lens-examples/src/main/resources/cube33.xml PRE-CREATION
lens-ml-dist/pom.xml c75e2ab91edf09858daf8fafde6ae8f514a66794
lens-ml-lib/pom.xml 959efe84898001f43508b6ce6edf1efc546968f7
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java ce3db4250e6fcd56236d1f8017e07cc0c048bcff
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java ff47353d4339774b73a89bc4f6d0243c08b2af69
lens-query-lib/pom.xml c21e77f786ac1a350675690add023c67f49ec15f
lens-regression/pom.xml a4f857d9b8f95cde89321679e092fda426ca57df
lens-server-api/pom.xml 93f79fff4fd21c830a7d66592ec4c5735cb8eb01
lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java 2667ebff252499cfc14c7925ee7f5e2fc007aa9e
lens-server/pom.xml 60ed1aeb540796b223aae2ed246de4d63341eefe
lens-ship-jars/pom.xml 67867a420da456fa72178c0b47030e1428eada29
lens-storage-db/pom.xml 68c6e46770f18c6360b6478f6535b844ca8a54a3
lens-ui/pom.xml 1185be90a6f9f91a354e62015f3af23bec36bf16
pom.xml af7dafa451bb5f7d2103e616d9cf6fac4946eddd
tools/scripts/generate-site-public.sh 109268ca92a53cd963669015a87aa6b14b321b1e
Diff: https://reviews.apache.org/r/59713/diff/1/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 59713: LENS-1427: ExpressionResolver is removing
expressions if they are not answerable by *any* candidates
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59713/#review176756
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On June 2, 2017, 9:41 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59713/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 9:41 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1427
> https://issues.apache.org/jira/browse/LENS-1427
>
>
> Repository: lens
>
>
> Description
> -------
>
> Should be at least one and *all*
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 7cad400bb12464c05b370a0aad5e7baec0248c1d
> lens-cube/src/test/resources/schema/cubes/base/b1cube.xml e3e99098f4a8dbee06e29b2a7af265b14b702aab
> lens-cube/src/test/resources/schema/cubes/base/b2cube.xml e5cf2c08959ffd1525b677e638f04944630e36dc
> lens-cube/src/test/resources/schema/cubes/base/testcube.xml f123341f5ecb2c2124e2a14c5768f6d04f5766fa
>
>
> Diff: https://reviews.apache.org/r/59713/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 59713: LENS-1427: ExpressionResolver is removing
expressions if they are not answerable by *any* candidates
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59713/
-----------------------------------------------------------
(Updated June 2, 2017, 3:11 p.m.)
Review request for lens.
Bugs: LENS-1427
https://issues.apache.org/jira/browse/LENS-1427
Repository: lens
Description
-------
Should be at least one and *all*
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 7cad400bb12464c05b370a0aad5e7baec0248c1d
lens-cube/src/test/resources/schema/cubes/base/b1cube.xml e3e99098f4a8dbee06e29b2a7af265b14b702aab
lens-cube/src/test/resources/schema/cubes/base/b2cube.xml e5cf2c08959ffd1525b677e638f04944630e36dc
lens-cube/src/test/resources/schema/cubes/base/testcube.xml f123341f5ecb2c2124e2a14c5768f6d04f5766fa
Diff: https://reviews.apache.org/r/59713/diff/2/
Changes: https://reviews.apache.org/r/59713/diff/1-2/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 59713: LENS-1427: ExpressionResolver is removing
expressions if they are not answerable by *any* candidates
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59713/#review176729
-----------------------------------------------------------
Patch needs to re-done with apache/master.
- Amareshwari Sriramadasu
On June 1, 2017, 12:32 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59713/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 12:32 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1427
> https://issues.apache.org/jira/browse/LENS-1427
>
>
> Repository: lens
>
>
> Description
> -------
>
> Should be at least one and *all*
>
>
> Diffs
> -----
>
> checkstyle/pom.xml 2902c6b5846ccb12dd9e72a3617c504fa274d6ff
> contrib/clients/pom.xml d7677a33c1ffd7e24478708246aef8fc4c4e127f
> contrib/clients/python/pom.xml ac842bd17e2c456340649f5b227766b931dca102
> contrib/pom.xml b36add0946fd536e9346e3aa009b2481ff03d96d
> lens-api/pom.xml ece443034845685ea07268af3ee8aa7a6a01dec2
> lens-cli/pom.xml 3640fdd70e25ee31a4d31ba54f3f5d3cc45c5855
> lens-client/pom.xml 5b94800d16fc23287e6e1a0d96aff866219a8e7a
> lens-cube/pom.xml deaeb3613dee4ad8cd2e54a1bbe7f6627f56cc8a
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89b3606383357f26cc4827069d0f7274158
> lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336abe8ee372150ba76b3bd972b321fc9669
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 47bce655e97e7225cfa2943e0b07dad25ac8fcc9
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 7cad400bb12464c05b370a0aad5e7baec0248c1d
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 038d689ab39f5f41c5a813dfcd2ecb9eb6f2e2ec
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13811f85a625b3d41fc4fd42a5ec8bc300a
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 6c0d91adac61405ddcf23e3844c6205dbd6917b1
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13e270bff42beb6f6b9c3f2578e3ed71321
> lens-cube/src/test/resources/schema/cubes/base/b1cube.xml e3e99098f4a8dbee06e29b2a7af265b14b702aab
> lens-cube/src/test/resources/schema/cubes/base/b2cube.xml e5cf2c08959ffd1525b677e638f04944630e36dc
> lens-cube/src/test/resources/schema/cubes/base/testcube.xml f123341f5ecb2c2124e2a14c5768f6d04f5766fa
> lens-dist/pom.xml fb49931dcc607e82c4e0fd2f1ae90c46543d40b9
> lens-dist/src/deb/control/postinst PRE-CREATION
> lens-driver-es/pom.xml 925020e9209f7686097710c9c274b0f452b5b93c
> lens-driver-hive/pom.xml 51205e9153c713083bc85ceadb27e78b40ed5d65
> lens-driver-jdbc/pom.xml 5acd5d25785c6a2c28bc8bac0b848620455d4c27
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 75153f669d5b45accb7e0ae52e854a685de8cae1
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 8e042d1e52eebcdeb044a3394d58d93f22c3e34a
> lens-driver-jdbc/src/test/resources/drivers/jdbc/jdbc1/jdbcdriver-site.xml ac5e43debbaa771d2723c29e24b3da980772c752
> lens-examples/pom.xml af467eeb1a71b06214bf8188e44f5f63328a7858
> lens-examples/src/main/resources/cube11.xml PRE-CREATION
> lens-examples/src/main/resources/cube22.xml PRE-CREATION
> lens-examples/src/main/resources/cube33.xml PRE-CREATION
> lens-ml-dist/pom.xml c75e2ab91edf09858daf8fafde6ae8f514a66794
> lens-ml-lib/pom.xml 959efe84898001f43508b6ce6edf1efc546968f7
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java ce3db4250e6fcd56236d1f8017e07cc0c048bcff
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java ff47353d4339774b73a89bc4f6d0243c08b2af69
> lens-query-lib/pom.xml c21e77f786ac1a350675690add023c67f49ec15f
> lens-regression/pom.xml a4f857d9b8f95cde89321679e092fda426ca57df
> lens-server-api/pom.xml 93f79fff4fd21c830a7d66592ec4c5735cb8eb01
> lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java 2667ebff252499cfc14c7925ee7f5e2fc007aa9e
> lens-server/pom.xml 60ed1aeb540796b223aae2ed246de4d63341eefe
> lens-ship-jars/pom.xml 67867a420da456fa72178c0b47030e1428eada29
> lens-storage-db/pom.xml 68c6e46770f18c6360b6478f6535b844ca8a54a3
> lens-ui/pom.xml 1185be90a6f9f91a354e62015f3af23bec36bf16
> pom.xml af7dafa451bb5f7d2103e616d9cf6fac4946eddd
> tools/scripts/generate-site-public.sh 109268ca92a53cd963669015a87aa6b14b321b1e
>
>
> Diff: https://reviews.apache.org/r/59713/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>