[jira] [Commented] (HBASE-16404) Make DeleteBloomFilters work with BloomContext

["Anoop Sam John (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-16404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418475#comment-15418475 ] 

Anoop Sam John commented on HBASE-16404:
----------------------------------------

Init of RowBloomContext for deleteFamily can be done where the deleteFamilyBloomFilterWriter is initialized rather than having null check every time during bloom write.  Here
{code}
// initialize delete family Bloom filter when there is NO RowCol Bloom
    // filter
    if (this.bloomType != BloomType.ROWCOL) {
      this.deleteFamilyBloomFilterWriter = BloomFilterFactory
          .createDeleteBloomAtWrite(conf, cacheConf,
              (int) Math.min(maxKeys, Integer.MAX_VALUE), writer);
    } else {
      deleteFamilyBloomFilterWriter = null;
    }
{code}
Else +1


> Make DeleteBloomFilters work with BloomContext
> ----------------------------------------------
>
>                 Key: HBASE-16404
>                 URL: https://issues.apache.org/jira/browse/HBASE-16404
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16404.patch
>
>
> Since we have added BloomFiltercontext to work with RowBlooms the same can be applied for DeleteBloomFilters also. Should be a simple change considering we have the infrastructure in place.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)