You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by sirpkt <gi...@git.apache.org> on 2014/12/18 08:20:35 UTC
[GitHub] tajo pull request: Fix data missing bug in order by null first
GitHub user sirpkt opened a pull request:
https://github.com/apache/tajo/pull/307
Fix data missing bug in order by null first
I changed setMaxRangeIfNull() method to set NULL as minimum value when null first is set
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sirpkt/tajo TAJO-1257
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/307.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #307
----
commit fa86d0967ac98fff08023e12f9b17a8d9e3eab6b
Author: sirpkt <si...@apache.org>
Date: 2014-12-18T07:16:06Z
Fix data missing bug in order by null first
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1257: ORDER BY with NULL FIRST misses some...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/307#issuecomment-67583202
Thank you for nice finding. After I test it on real cluster, I'll give reviews.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1257: ORDER BY with NULL FIRST misses some...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/307
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1257: ORDER BY with NULL FIRST misses some...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/307#issuecomment-70046306
@sirpkt
+1 LGTM
I'm sorry for late review. I missed the review for few days. Ship it. Thank you for your contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1257: ORDER BY with NULL FIRST misses some...
Posted by sirpkt <gi...@git.apache.org>.
Github user sirpkt commented on the pull request:
https://github.com/apache/tajo/pull/307#issuecomment-70612082
Thank you for the review, @hyunsik .
I just committed the patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1257: ORDER BY with NULL FIRST misses some...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/307#issuecomment-68916077
I'm sorry for late review. I tested various cases. It seems to work correctly.
BTW, I found another bug, I don't think that your patch causes this problem. But, you may have interested in this problem.
https://issues.apache.org/jira/browse/TAJO-1283
I'll finish your review by tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---