[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change in pull request #11: Add field for browser perf service

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #11: Add field for browser perf service
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/11#discussion_r364223549
 
 

 ##########
 File path: browser/BrowserPerf.proto
 ##########
 @@ -33,10 +33,14 @@ message BrowserPerfData {
     int32 serviceId = 1;
     // Service version in browser is the Instance concept in the backend.
     int32 serviceVersionId = 2;
+    // Data time
+    int64 time = 3; // assignment by the backend
+    // Page path in browser is the endpoint concept in the backend
     // Page path in the browser, mostly it is URI, without parameter
-    string pagePath = 3;
-    repeated BrowserErrorLog logs = 4;
-    PerfDetail perfDetail = 5;
+    string pagePath = 4;
+    int32 pagePathId = 5; // assignment by the backend
 
 Review comment:
   Same here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services