[jira] [Comment Edited] (MYFACES-4233) Support generics return type on myfaces-builder-plugin

["Paul Nicolucci (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496848#comment-16496848 ] 

Paul Nicolucci edited comment on MYFACES-4233 at 5/31/18 5:53 PM:
------------------------------------------------------------------

My initial thought here is that we might need to update our qdox version that is being used. Currently the 1.12 version is used and in org.apache.myfaces.buildtools.maven2.plugin.builder.MakeComponentMojo.java we're doing the following:

private String getInnerSourceCode(JavaDocBuilder builder, ComponentMeta component)
{
....
//Get declaration signature in a way that we don't need
                //to declare imports.
                String declaration = method.getDeclarationSignature(true);
                                
....
}

It is possible that's not dealing with Generics properly.


was (Author: paul.nicolucci):
My initial thought here is that we might need to update our qdox version that is being used. Currently the 1.12 version is used and in org.apache.myfaces.buildtools.maven2.plugin.builder.MakeComponentMojo.java we're doing the following:

private String getInnerSourceCode(JavaDocBuilder builder, ComponentMeta component)
{
....
//Get declaration signature in a way that we don't need
                //to declare imports.
                String declaration = method.getDeclarationSignature(true);
                                
....
}

It's possible that's not dealing with Generics properly.

> Support generics return type on myfaces-builder-plugin
> ------------------------------------------------------
>
>                 Key: MYFACES-4233
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4233
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-372
>            Reporter: Eduardo Breijo
>            Priority: Minor
>
> On the JIRA issue below, there was an issue with the _UIWebsocket.getEventNames() method where the generic <String> in the return type of the method was missing in the auto-generated file UIWebsocket.
> {code:java}
> //BEGIN CODE COPIED FROM javax.faces.component._UIWebsocket 
> public java.util.Collection getEventNames()
> {code}
> JIRA issue: https://issues.apache.org/jira/browse/MYFACES-4232
>  
> To workaround this, the api/src/main/resources/META-INF/componentClass20.vm file was modified to actually generate the getEventNames() method with the correct return type. 
>  
> But I think we should fix this in the myfaces-builder-plugin, and then revert back the changes in the componentClass20.vm and javax.faces.component._UIWebsocket files.
>  
> I'm not familiar with the myfaces-builder-plugin, so any help here would be appreciated.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)