[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #5993: [IOTDB-3232] Implement read interface for WAL

[GitBox <gi...@apache.org>]

OneSizeFitsQuorum commented on code in PR #5993:
URL: https://github.com/apache/iotdb/pull/5993#discussion_r880337285


##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/plan/node/write/InsertMultiTabletsNode.java:
##########
@@ -119,11 +128,13 @@ public void addInsertTabletNode(InsertTabletNode node, Integer parentIndex) {
 
   @Override
   public void setSearchIndex(long index) {
+    searchIndex = index;

Review Comment:
   Why need this?



##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/plan/node/write/InsertNode.java:
##########
@@ -71,7 +71,10 @@ public abstract class InsertNode extends WritePlanNode implements IConsensusRequ
    */
   protected IDeviceID deviceID;
 
-  /** this index is used by wal search, its order should be protected by the upper layer */
+  /**
+   * this index is used by wal search, its order should be protected by the upper layer, and the

Review Comment:
   I have abided by this rule



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org