You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/24 09:32:31 UTC
[GitHub] [shardingsphere] kimmking opened a new pull request #8317: convert object to string before set properties to SPI instance
kimmking opened a new pull request #8317:
URL: https://github.com/apache/shardingsphere/pull/8317
Fixes #8204.
Changes proposed in this pull request:
- convert object to string before set properties to SPI instance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #8317: convert object to string before set properties to SPI instance
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #8317:
URL: https://github.com/apache/shardingsphere/pull/8317
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #8317: convert object to string before set properties to SPI instance
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #8317:
URL: https://github.com/apache/shardingsphere/pull/8317#discussion_r529476601
##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/spi/typed/TypedSPIRegistry.java
##########
@@ -64,4 +64,12 @@
}
throw new ServiceProviderNotFoundException(typedSPIClass);
}
+
+ private static <T extends TypedSPI> void convertPropertiesValueType(final Properties props, final T result) {
Review comment:
input param should not name as `result`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org