You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Benedict Elliott Smith (Jira)" <ji...@apache.org> on 2020/02/17 23:43:00 UTC

[jira] [Commented] (CASSANDRA-15308) Fix flakey testAcquireReleaseOutbound - org.apache.cassandra.net.ConnectionTest

    [ https://issues.apache.org/jira/browse/CASSANDRA-15308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038682#comment-17038682 ] 

Benedict Elliott Smith commented on CASSANDRA-15308:
----------------------------------------------------

I don't know if I was just expressing myself poorly, but I don't _think_ your comment addressed my concern.  However, I've taken a look at the test myself and the issue I worried about is not a problem.

Is there a reason you don't simply release all remaining capacity, as opposed to looping releasing {{acquireStep}}?

> Fix flakey testAcquireReleaseOutbound - org.apache.cassandra.net.ConnectionTest
> -------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15308
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15308
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: Joey Lynch
>            Assignee: Yifan Cai
>            Priority: Normal
>             Fix For: 4.0-alpha
>
>
> Example failure: https://circleci.com/gh/jolynch/cassandra/554#tests/containers/61
> {noformat}
> Your job ran 4428 tests with 1 failure
> - testAcquireReleaseOutbound - org.apache.cassandra.net.ConnectionTest
> junit.framework.AssertionFailedError
> 	at org.apache.cassandra.net.ConnectionTest.lambda$testAcquireReleaseOutbound$53(ConnectionTest.java:770)
> 	at org.apache.cassandra.net.ConnectionTest.lambda$doTest$8(ConnectionTest.java:238)
> 	at org.apache.cassandra.net.ConnectionTest.doTestManual(ConnectionTest.java:258)
> 	at org.apache.cassandra.net.ConnectionTest.doTest(ConnectionTest.java:236)
> 	at org.apache.cassandra.net.ConnectionTest.test(ConnectionTest.java:225)
> 	at org.apache.cassandra.net.ConnectionTest.testAcquireReleaseOutbound(ConnectionTest.java:767) {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org