[GitHub] [pulsar] poorbarcode commented on a diff in pull request #17632: [improve][broker] Cancel the loadShedding task when closing pulsar service

[GitBox <gi...@apache.org>]

poorbarcode commented on code in PR #17632:
URL: https://github.com/apache/pulsar/pull/17632#discussion_r970363464


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LoadSheddingTask.java:
##########
@@ -52,25 +55,24 @@ public void run() {
         } catch (Exception e) {

Review Comment:
   In the first line of method `run` method, we can add a check to make quick failure:
   
   ```java
   
   public void run(){
       if (isCancel){
           return;
       }
       ...
   }
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org