You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/02/25 04:42:04 UTC
[GitHub] [arrow-datafusion] jackwener opened a new pull request, #5393: minor: add forgotten large_utf8
jackwener opened a new pull request, #5393:
URL: https://github.com/apache/arrow-datafusion/pull/5393
# Which issue does this PR close?
N/A
# Rationale for this change
https://github.com/apache/arrow-datafusion/pull/5384#discussion_r1116851452
we missed DataType::LargeUtf8 in https://github.com/apache/arrow-datafusion/pull/5234.
# What changes are included in this PR?
add forgotten large_utf8
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5393: minor: add forgotten large_utf8
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5393:
URL: https://github.com/apache/arrow-datafusion/pull/5393#issuecomment-1445141172
Benchmark runs are scheduled for baseline = 248d6fc1b5aa540147cc87debd90105b1d1ad2c0 and contender = 645428f59b838d0b6a2d3289089ec038932de93a. 645428f59b838d0b6a2d3289089ec038932de93a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4d8bba759cb840ebb9af5be9bb0d9d54...157be45619cf4b259ae93ada6e11b37c/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/0a2de141170e44b3b1b9a7cfc8877dcf...3d7a14c1b2fd4b7eb6383e80f1189be7/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/896d8f6a7f9a46cf820142cc265cc8a6...793d3d8253c24faeb387a2272c9b64c0/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f9bb262ff82840c6b9d586e5091e8c31...8face61c16764d36839f4b0792e75b21/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener merged pull request #5393: minor: add forgotten large_utf8
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #5393:
URL: https://github.com/apache/arrow-datafusion/pull/5393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org