[jira] Commented: (MNG-178) filter definition

["Brett Porter (JIRA)" <ji...@codehaus.org>]

     [ http://jira.codehaus.org/browse/MNG-178?page=comments#action_31997 ]
     
Brett Porter commented on MNG-178:
----------------------------------

There are a few things I'd like to see corrected before applying this:
- remove the utility functions and use org.codehaus.plexus.util.InterpolationFilterReader
- provide some way to exclude files from filtering (binaries), eg:
<filterExcludes>
  <filterExclude>**/*.jar</filterExclude>
  <filterExclude>**/*.bin</filterExclude>
</filterExcludes>
I think this should be in the resources section ultimately, but I'm happy to start here. You can find help in FileUtils for getting files with patterns (resources mojo should already be using them).

additionally:
- use the standard formatting, and don't rearrange elements not touched (shorter diffs are easier to read)
- use unified diff format (-uN)

thanks!

> filter definition
> -----------------
>
>          Key: MNG-178
>          URL: http://jira.codehaus.org/browse/MNG-178
>      Project: m2
>         Type: Improvement
>     Reporter: Brett Porter
>  Attachments: 178-patch.gz, MNG-178-patch-2.gz, MNG-178-patch.gz, MNG-178-update.tgz
>
>
> we need to be able to define filters for resources. It should be configurable by different profiles, and include properties files as well as individual property files.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org