[GitHub] [bookkeeper] StevenLuMT commented on a diff in pull request #3437: Issue #2220: support skip invalid record in recovery

[GitBox <gi...@apache.org>]

StevenLuMT commented on code in PR #3437:
URL: https://github.com/apache/bookkeeper/pull/3437#discussion_r936169723


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieImpl.java:
##########
@@ -618,7 +618,7 @@ private void replay(Journal journal, JournalScanner scanner) throws IOException
                 logPosition = markedLog.getLogFileOffset();
             }
             LOG.info("Replaying journal {} from position {}", id, logPosition);
-            long scanOffset = journal.scanJournal(id, logPosition, scanner);
+            long scanOffset = journal.scanJournal(id, logPosition, scanner, this.conf.isSkipReplayJournalInvalidRecord());

Review Comment:
   I have a question:
   How do we decide to open the switch
   What I understand is that open this switch ,maube cause to loss data,
   does this need to discuss it on the dev@ mailing list @eolivelli , have a look,thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org