[fineract] branch vorburger-patch-1 created (now 39c6aca)

[vo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

vorburger pushed a change to branch vorburger-patch-1
in repository https://gitbox.apache.org/repos/asf/fineract.git.


      at 39c6aca  add (obvious) rebase step to PR Help in README

This branch includes the following new commits:

     new 39c6aca  add (obvious) rebase step to PR Help in README

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[fineract] 01/01: add (obvious) rebase step to PR Help in README

[vo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

vorburger pushed a commit to branch vorburger-patch-1
in repository https://gitbox.apache.org/repos/asf/fineract.git

commit 39c6acaf1e6520356be1325e0603aee21f4b6640
Author: Michael Vorburger ⛑️ <mi...@vorburger.ch>
AuthorDate: Wed Apr 29 12:07:21 2020 +0200

    add (obvious) rebase step to PR Help in README
---
 README.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/README.md b/README.md
index d3f89b0..3cdcbd9 100644
--- a/README.md
+++ b/README.md
@@ -257,6 +257,7 @@ If your PR is failing to pass our CI build due to a test failure, then:
 1. Understand if the failure is due to your PR or an unrelated unstable test.
 1. If you suspect it is because of a "flaky" test, and not due to a change in your PR, then please do not simply wait for an active maintainer to come and help you, but instead be a proactive contributor to the project - see next steps.
 1. Search for the name of the failed test on https://issues.apache.org/jira/, e.g. for `AccountingScenarioIntegrationTest` you would find [FINERACT-899](https://issues.apache.org/jira/browse/FINERACT-899).
+1. If you happen to read in such bugs that tests were just recently fixed, or ignored, then rebase your PR to pick up that change.
 1. If you find previous comments "proving" that the same test has arbitrarily failed in at least 3 past PRs, then please do yourself raise a small separate new PR proposing to add an `@Ignore // TODO FINERACT-123` to the respective unstable test (e.g. [#774](https://github.com/apache/fineract/pull/774)) with the commit message mentioning said JIRA, as always.  (Please do NOT just `@Ignore` any existing tests mixed in as part of your larger PR.)
 1. If there is no existing JIRA for the test, then first please evaluate whether the failure couldn't be a (perhaps strange) impact of the change you are proposing after all.  If it's not, then please raise a new JIRA to document the suspected Flaky Test, and link it to [FINERACT-850](https://issues.apache.org/jira/browse/FINERACT-850).  This will allow the next person coming along hitting the same test failure to easily find it, and eventually propose to ignore the unstable test.
 1. Then (only) Close and Reopen your PR, which will cause a new build, to see if it passes.