[GitHub] [airflow] josh-fell commented on a diff in pull request #25453: modify FacebookAdsReportingHook to pass Facebook access token in the …

[GitBox <gi...@apache.org>]

josh-fell commented on code in PR #25453:
URL: https://github.com/apache/airflow/pull/25453#discussion_r936183279


##########
airflow/providers/facebook/ads/hooks/ads.py:
##########
@@ -92,7 +92,7 @@ def facebook_ads_config(self) -> Dict:
         """
         self.log.info("Fetching fb connection: %s", self.facebook_conn_id)
         conn = self.get_connection(self.facebook_conn_id)
-        config = conn.extra_dejson
+        config = {**conn.extra_dejson, "access_token": conn.password}

Review Comment:
   Should there be some warning/message to the user noting that they should set `access_token` in the Connection's `password` attr rather than in Extras as well?
   
   Side note, this hook desperately needs some documentation re: setting up a connection.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org