You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2023/05/25 20:29:34 UTC

[GitHub] [tvm] Lunderberg opened a new pull request, #14958: [Codegen][LLVM] Allow void return type from PackedFunc

Lunderberg opened a new pull request, #14958:
URL: https://github.com/apache/tvm/pull/14958

   Previously, calling a packed func that returns void would result in an error being raised from `tir::APIType`, as there is no runtime representation of a void type.  This commit updates `CodeGenCPU::MakeCallPackedLowered` to only read the return value and type of a `PackedFunc` when the TIR return type is non-void.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Lunderberg commented on pull request #14958: [Codegen][LLVM] Allow void return type from PackedFunc

Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.

Lunderberg commented on PR #14958:
URL: https://github.com/apache/tvm/pull/14958#issuecomment-1563470668

   To allow CI to run, the commit for the bugfix in https://github.com/apache/tvm/pull/14950 is in this PR, but is the same commit ID and shouldn't result in any merge conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14958: [Codegen][LLVM] Allow void return type from PackedFunc

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.

tvm-bot commented on PR #14958:
URL: https://github.com/apache/tvm/pull/14958#issuecomment-1563469119

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * No users to tag found in teams: `codegen`, `llvm` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen merged pull request #14958: [Codegen][LLVM] Allow void return type from PackedFunc

Posted by "tqchen (via GitHub)" <gi...@apache.org>.

tqchen merged PR #14958:
URL: https://github.com/apache/tvm/pull/14958


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org