You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Robert Mohn (JIRA)" <ji...@codehaus.org> on 2007/08/08 16:17:13 UTC
[jira] Created: (MNG-3141) Build not working if pom.xml is a
symbolic link
Build not working if pom.xml is a symbolic link
-----------------------------------------------
Key: MNG-3141
URL: http://jira.codehaus.org/browse/MNG-3141
Project: Maven 2
Issue Type: Bug
Affects Versions: 2.0.7
Reporter: Robert Mohn
We are running on Ubuntu and our environment is as follows:
./pom.xml (is a symbolic link to /baseline/pom.xml)
./module/pom.xml (is a symbolic link to /baseline/module/pom.xml)
If you go into the module directory and run a compile (mvn compile), everything works fine.
If you try to run a compile from the parent pom, maven does not resolve the basedir correctly when it tries to compile the module. It tries to create the target directory in /baseline/module/target, rather than in the local module directory.
Everything works as expected in release 2.0.6. Something changed with the symbolic link resolution in 2.0.7 that breaks my builds.
-Rob
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3141) Build not working if pom.xml is a
symbolic link
Posted by "Robert Mohn (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104314 ]
Robert Mohn commented on MNG-3141:
----------------------------------
I haven't been able to verify this, but from looking at the code, it looks like the following change:
revision 543362, Fri Jun 1 02:29:37 2007 UTC
on the file:
maven-2.0.x/maven-core/src/main/java/org/apache/maven/DefaultMaven.java
is causing the problem.
> Build not working if pom.xml is a symbolic link
> -----------------------------------------------
>
> Key: MNG-3141
> URL: http://jira.codehaus.org/browse/MNG-3141
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 2.0.7
> Reporter: Robert Mohn
>
> We are running on Ubuntu and our environment is as follows:
> ./pom.xml (is a symbolic link to /baseline/pom.xml)
> ./module/pom.xml (is a symbolic link to /baseline/module/pom.xml)
> If you go into the module directory and run a compile (mvn compile), everything works fine.
> If you try to run a compile from the parent pom, maven does not resolve the basedir correctly when it tries to compile the module. It tries to create the target directory in /baseline/module/target, rather than in the local module directory.
> Everything works as expected in release 2.0.6. Something changed with the symbolic link resolution in 2.0.7 that breaks my builds.
> -Rob
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-3141) Build not working if pom.xml is a
symbolic link
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter closed MNG-3141.
-----------------------------
Resolution: Fixed
Fix Version/s: 2.0.8
I wasn't able to apply your patch, since AFAICT that would simply revert the previous issue (on Windows, it would not canonicalize either do to the check).
Instead, I used an Os.isFamily check to only canonicalize on Windows.
> Build not working if pom.xml is a symbolic link
> -----------------------------------------------
>
> Key: MNG-3141
> URL: http://jira.codehaus.org/browse/MNG-3141
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 2.0.7
> Reporter: Robert Mohn
> Assignee: Brett Porter
> Fix For: 2.0.8
>
> Attachments: DefaultMaven.java.patch
>
>
> We are running on Ubuntu and our environment is as follows:
> ./pom.xml (is a symbolic link to /baseline/pom.xml)
> ./module/pom.xml (is a symbolic link to /baseline/module/pom.xml)
> If you go into the module directory and run a compile (mvn compile), everything works fine.
> If you try to run a compile from the parent pom, maven does not resolve the basedir correctly when it tries to compile the module. It tries to create the target directory in /baseline/module/target, rather than in the local module directory.
> Everything works as expected in release 2.0.6. Something changed with the symbolic link resolution in 2.0.7 that breaks my builds.
> -Rob
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3141) Build not working if pom.xml is a
symbolic link
Posted by "Robert Mohn (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Mohn updated MNG-3141:
-----------------------------
Attachment: DefaultMaven.java.patch
Patch for the issue. The patch checks if the file is a symlink before doing the getCanonicalFile conversion. The 'isSymLink' method was taken from CleanMojo.java -- so at some point we should move that method into a utility class.
> Build not working if pom.xml is a symbolic link
> -----------------------------------------------
>
> Key: MNG-3141
> URL: http://jira.codehaus.org/browse/MNG-3141
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 2.0.7
> Reporter: Robert Mohn
> Attachments: DefaultMaven.java.patch
>
>
> We are running on Ubuntu and our environment is as follows:
> ./pom.xml (is a symbolic link to /baseline/pom.xml)
> ./module/pom.xml (is a symbolic link to /baseline/module/pom.xml)
> If you go into the module directory and run a compile (mvn compile), everything works fine.
> If you try to run a compile from the parent pom, maven does not resolve the basedir correctly when it tries to compile the module. It tries to create the target directory in /baseline/module/target, rather than in the local module directory.
> Everything works as expected in release 2.0.6. Something changed with the symbolic link resolution in 2.0.7 that breaks my builds.
> -Rob
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira