You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Justin Erenkrantz <ju...@erenkrantz.com> on 2005/06/07 23:12:46 UTC
Re: svn commit: r188846 - in /httpd/httpd/trunk:
include/mpm_common.h server/mpm_common.c
--On Tuesday, June 7, 2005 7:13 PM +0000 niq@apache.org wrote:
> +APR_HOOK_STRUCT(
> +#if AP_ENABLE_EXCEPTION_HOOK
> + APR_HOOK_LINK(fatal_exception)
> +#endif
> + APR_HOOK_LINK(monitor)
> +)
> +
gcc (at least the one on RHEL3) forbids the use of preprocessor
conditionals inside of a macro. So, this needs to be:
#if AP_ENABLE_EXCEPTION_HOOK
...define with it in there...
#else
...define without fatal_exception...
#endif
Thanks. -- justin
Re: svn commit: r188846 - in /httpd/httpd/trunk:
include/mpm_common.h server/mpm_common.c
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On Wednesday, June 8, 2005 12:49 AM +0100 Nick Kew <ni...@webthing.com>
wrote:
> OK, I've updated it thusly. But what version of gcc is that?
> I'm using gcc 3.3.4, and that was happy with it.
% gcc -v
Reading specs from /usr/lib/gcc-lib/ia64-redhat-linux/3.2.3/specs
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man
--infodir=/usr/share/info --enable-shared --enable-threads=posix
--disable-checking --with-system-zlib --enable-__cxa_atexit
--host=ia64-redhat-linux
Thread model: posix
gcc version 3.2.3 20030502 (Red Hat Linux 3.2.3-52)
HTH. Thanks! -- justin
Re: svn commit: r188846 - in /httpd/httpd/trunk: include/mpm_common.h
server/mpm_common.c
Posted by Nick Kew <ni...@webthing.com>.
Justin Erenkrantz wrote:
> --On Tuesday, June 7, 2005 7:13 PM +0000 niq@apache.org wrote:
>
>> +APR_HOOK_STRUCT(
>> +#if AP_ENABLE_EXCEPTION_HOOK
>> + APR_HOOK_LINK(fatal_exception)
>> +#endif
>> + APR_HOOK_LINK(monitor)
>> +)
>> +
>
>
> gcc (at least the one on RHEL3) forbids the use of preprocessor
> conditionals inside of a macro. So, this needs to be:
>
> #if AP_ENABLE_EXCEPTION_HOOK
> ...define with it in there...
> #else
> ...define without fatal_exception...
> #endif
>
> Thanks. -- justin
OK, I've updated it thusly. But what version of gcc is that?
I'm using gcc 3.3.4, and that was happy with it.
--
Nick Kew