[GitHub] [superset] codyml commented on a diff in pull request #20728: [WIP] feature(dashboard): Drill to detail modal

[GitBox <gi...@apache.org>]

codyml commented on code in PR #20728:
URL: https://github.com/apache/superset/pull/20728#discussion_r927767653


##########
superset-frontend/packages/superset-ui-core/src/query/types/Query.ts:
##########
@@ -32,23 +32,30 @@ import { PostProcessingRule } from './PostProcessing';
 import { JsonObject } from '../../connection';
 import { TimeGranularity } from '../../time-format';
 
-export type QueryObjectFilterClause = {
+export type BaseQueryObjectFilterClause = {
   col: QueryFormColumn;
   grain?: TimeGranularity;
   isExtra?: boolean;

Review Comment:
   With this refactoring I was trying to keep everything the same except allow the specific types of filter clauses (binary, set, unary) to be exported/imported separately, as TypeScript was complaining because `val` was optional on the union `QueryObjectFilterClause` type.  If I did it right `grain` and `isExtra` should still be present on all specific filter clause types and the union `QueryObjectFilterClause` type – does that work?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org