You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Alexander Murmann (Jira)" <ji...@apache.org> on 2021/10/08 18:57:00 UTC
[jira] [Updated] (GEODE-9702) public setters added to
GatewaySender, not caught by japicmp
[ https://issues.apache.org/jira/browse/GEODE-9702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Murmann updated GEODE-9702:
-------------------------------------
Labels: needsTriage (was: )
> public setters added to GatewaySender, not caught by japicmp
> ------------------------------------------------------------
>
> Key: GEODE-9702
> URL: https://issues.apache.org/jira/browse/GEODE-9702
> Project: Geode
> Issue Type: Bug
> Components: wan
> Affects Versions: 1.15.0
> Reporter: Owen Nichols
> Priority: Major
> Labels: needsTriage
>
> In 1.15.0, new methods were added to Geode's public interface such as `GatewaySender.getRetriesToGetTransactionEventsFromQueue`. While adding methods _is_ compatible with existing source and binary calls to this interface, it breaks anything else that implements this interface. _Even if_ a default implementation had been provided, there are still edge cases where it could collide with existing implementation that may already have methods with those names.
> Possible solutions:
> 1. add default implementation, and ignore the edge case
> 2. remove the public getters
> 3. create a new interface extending the old one, in which to add the new getters
> Also: look into why japicmp checks did not fail when these new public setters and getters were first added back in April.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)