You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@wandisco.com> on 2015/02/03 12:50:52 UTC
Re: svn commit: r1656694 - in /subversion/trunk/subversion: include/private/svn_ra_private.h
include/svn_ra.h libsvn_client/diff.c libsvn_ra/ra_loader.c
On 03.02.2015 12:49, rhuijben@apache.org wrote:
> Author: rhuijben
> Date: Tue Feb 3 11:49:13 2015
> New Revision: 1656694
>
> URL: http://svn.apache.org/r1656694
> Log:
> Rename svn_ra_dup_session() (public api) to svn_ra__dup_session (private api).
+1000
Re: svn commit: r1656694 - in /subversion/trunk/subversion: include/private/svn_ra_private.h
include/svn_ra.h libsvn_client/diff.c libsvn_ra/ra_loader.c
Posted by Branko Čibej <br...@wandisco.com>.
On 03.02.2015 13:28, Julian Foad wrote:
> Branko Čibej wrote:
>> On 03.02.2015 12:49, rhuijben@apache.org wrote:
>>> URL: http://svn.apache.org/r1656694
>>> Log:
>>> Rename svn_ra_dup_session() (public api) to svn_ra__dup_session (private
>> api).
>>
>> +1000
> Presumably you both have in mind some reason why this change is beneficial. (I saw you discussing on IRC about it being "unsafe" or some such.) Could you please hint at the reason for this, in the log message?
There are severe constraints on where and how one may use the duplicate
session. Rather than explain them at length in docs and deal with tons
of spurious bug reports, I think it's better to keep this for private
use within libsvn_client; *especially* if we manage to merge the
reuse-ra-session branch to trunk, where use of duplicate sessions that
may be based on something that's managed by libsvn_client's session
cache is far too error-prone to be useful.
The RA session cache will, in most cases, make session duplication less
useful anyway.
-- Brane
Re: svn commit: r1656694 - in /subversion/trunk/subversion: include/private/svn_ra_private.h include/svn_ra.h libsvn_client/diff.c libsvn_ra/ra_loader.c
Posted by Julian Foad <ju...@btopenworld.com>.
Branko Čibej wrote:
> On 03.02.2015 12:49, rhuijben@apache.org wrote:
>> URL: http://svn.apache.org/r1656694
>> Log:
>> Rename svn_ra_dup_session() (public api) to svn_ra__dup_session (private
> api).
>
> +1000
Presumably you both have in mind some reason why this change is beneficial. (I saw you discussing on IRC about it being "unsafe" or some such.) Could you please hint at the reason for this, in the log message?
- Julian