You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Adam B <ad...@mesosphere.io> on 2015/09/12 11:50:22 UTC
Re: Review Request 32700: Removed FrameworkID from FrameworkState.
> On Aug. 3, 2015, 6:41 p.m., Adam B wrote:
> > Looks great! Just a couple of questions.
> > Did you run `sudo make check`, since you modified `ROOT_` tests?
@karya, should we revive this patch now, or discard it?
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32700/#review93988
-----------------------------------------------------------
On Aug. 1, 2015, 12:13 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32700/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2015, 12:13 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-905
> https://issues.apache.org/jira/browse/MESOS-905
>
>
> Repository: mesos
>
>
> Description
> -------
>
> FrameworkState already has FrameworkInfo which will have a valid FrameworkID.
>
> NOTE: This patch is only to be merged _ONLY_ after all the dependent patches have shipped, i.e. after 0.23.0 (tracked here: https://issues.apache.org/jira/browse/MESOS-2561) has released.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b
> src/slave/containerizer/external_containerizer.cpp d3640e7beaa7a99d7c8938025af879e19cd6b470
> src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1
> src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1
> src/slave/state.hpp cecf200e6e79172af57ae195a73a5161be7e604a
> src/slave/state.cpp b9f2d8a0d6395b92bd50f1e0927f3ae9fd04b81c
> src/slave/status_update_manager.cpp 1978ac8ab370f3e20f5c3c803beda468edf31e2c
> src/tests/containerizer/docker_containerizer_tests.cpp 80ed60e2b0fa39e8302867a7cb6a7388c25f9a40
> src/tests/containerizer/mesos_containerizer_tests.cpp 213fa4b0b9c50eba941ef11116b52497eb32d539
>
> Diff: https://reviews.apache.org/r/32700/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Kapil Arya
>
>