[GitHub] [inlong] healchow commented on a diff in pull request #4760: [INLONG-4715][Manager] Fix exception when no sink info is configured

[GitBox <gi...@apache.org>]

healchow commented on code in PR #4760:
URL: https://github.com/apache/inlong/pull/4760#discussion_r905693244


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sort/CreateSortConfigListenerV2.java:
##########
@@ -91,6 +92,11 @@ public ListenerResult listen(WorkflowContext context) throws Exception {
         InlongGroupInfo groupInfo = form.getGroupInfo();
         List<InlongStreamInfo> streamInfos = form.getStreamInfos();
         final String groupId = groupInfo.getInlongGroupId();
+        List<StreamSink> streamSinks = sinkService.listSink(groupId, null);
+        if (CollectionUtils.isEmpty(streamSinks)) {
+            log.info("No sinks configured, assuming direct consumption from MQ");

Review Comment:
   Suggest changing the log level to warn, and changing the log info to `not any sinks found for groupId={}, skip to create sort config`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org