[GitHub] [tvm] mbrookhart commented on a change in pull request #8866: Set default value of p in LpPool as 2

[GitBox <gi...@apache.org>]

mbrookhart commented on a change in pull request #8866:
URL: https://github.com/apache/tvm/pull/8866#discussion_r700322927



##########
File path: tests/python/frontend/onnx/test_forward.py
##########
@@ -3296,6 +3299,15 @@ def verify_lppool(x_shape, kernel_shape, p, strides, pads, out_shape, auto_pad="
         out_shape=[1, 1, 16, 16, 16],
         auto_pad="SAME_UPPER",
     )
+    # Pool2D with empty p
+    verify_lppool(
+        x_shape=[1, 1, 32, 32],
+        kernel_shape=[3, 3],
+        p=None,
+        strides=[1, 1],
+        pads=[1, 1, 1, 1],
+        out_shape=[1, 1, 31, 31],

Review comment:
       Yeah, with unity strides, I'm pretty sure the output shape here should be [1, 1, 32, 32]




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org