[jira] [Closed] (OFBIZ-13731) Take Apache POI for the pricat plugin from the framework version catalog

["Mridul Pathak (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-13731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mridul Pathak closed OFBIZ-13731.
---------------------------------
    Fix Version/s: Upcoming Branch
       Resolution: Fixed

> Take Apache POI for the pricat plugin from the framework version catalog
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-13731
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-13731
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: pricat
>    Affects Versions: Upcoming Branch
>            Reporter: Mridul Pathak
>            Assignee: Mridul Pathak
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>
> pricat declares {{poi-ooxml}}, {{poi-ooxml-schemas}}, {{poi-excelant}} and {{poi-scratchpad}} 4.1.2 in {{pricat/build.gradle}}, while the framework uses POI 5.5.1. Plugin libraries share the framework's classpath, so Gradle lifts {{poi}} and {{poi-ooxml}} to 5.5.1 but keeps {{poi-ooxml-schemas}}, {{poi-excelant}} and {{poi-scratchpad}} 4.1.2 next to them. The runtime then carries two copies of the OOXML schema classes ({{poi-ooxml-schemas}} 4.1.2 and {{poi-ooxml-lite}} 5.5.1) and a mixed POI version set. Dependabot's POI updates for pricat cannot build because {{poi-ooxml-schemas}} has no release after 4.1.2.
> Fix: declare {{libs.poi.ooxml}} from the framework version catalog in {{pricat/build.gradle}} and drop {{poi-ooxml-schemas}}, {{poi-excelant}} and {{poi-scratchpad}}, which pricat does not use. Replace the reflection in {{OFBizPricatUtil}} with direct calls to {{XSSFSheet.getVMLDrawing}} and {{XSSFVMLDrawing.findCommentShape}}, which are public since POI 5.
> Acceptance criteria: the runtime classpath has a single POI version set taken from the framework catalog, and pricat price-catalog upload, parsing, the HTML report and the import work as before.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)