[GitHub] [incubator-superset] john-bodley commented on pull request #10078: refactor: Break up superset/views/core.py

[GitBox <gi...@apache.org>]

john-bodley commented on pull request #10078:
URL: https://github.com/apache/incubator-superset/pull/10078#issuecomment-645750438


   @willbarrett thanks for the change.
   
   Unrelated to this change (but relevant to the `superset.views` module) I think we should probably strive to use `base.py` to represent base classes which get extended and `core.py` (or similar) to represent core logic (including functions). I think at the moment there isn't a clear divide between the two.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org