[jira] [Commented] (SAMZA-1416) Better logging around the exception where class loading failed in initializing the SystemFactory for a input/output system

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168663#comment-16168663 ] 

ASF GitHub Bot commented on SAMZA-1416:
---------------------------------------

GitHub user dnishimura opened a pull request:

    https://github.com/apache/samza/pull/296

    SAMZA-1416 : Better logging around the exception where class loading failed in initializing the SystemFactory for a input/output system

    Also added test coverage for the Util.getObj method.
    @nickpan47 @jmakes 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dnishimura/samza samza-1416

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/296.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #296
    
----
commit a0e70da78925c6a3fdf9f51ae3e2e34d132d0dd1
Author: Daniel Nishimura <dn...@gmail.com>
Date:   2017-09-15T23:07:15Z

    Added better logging to Util.getObj method when exception is thrown.

----


> Better logging around the exception where class loading failed in initializing the SystemFactory for a input/output system
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SAMZA-1416
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1416
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Yi Pan (Data Infrastructure)
>
> Currently, there is no log line showing the failure is on which system and which class name failed, when the config variable exists but is an empty string.
> {code}
>     val systemFactories = systemNames.map(systemName => {
>       val systemFactoryClassName = config
>         .getSystemFactory(systemName)
>         .getOrElse(throw new SamzaException("A stream uses system %s, which is missing from the configuration." format systemName))
>       (systemName, Util.getObj[SystemFactory](systemFactoryClassName))
>     }).toMap
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)