You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/19 07:52:25 UTC

[GitHub] [shardingsphere] terrymanu opened a new pull request #8220: Refactor TextProtocolBackendHandler.getRowData

terrymanu opened a new pull request #8220:
URL: https://github.com/apache/shardingsphere/pull/8220


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #8220: Refactor TextProtocolBackendHandler.getRowData

Posted by GitBox <gi...@apache.org>.

tristaZero merged pull request #8220:
URL: https://github.com/apache/shardingsphere/pull/8220


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #8220: Refactor TextProtocolBackendHandler.getRowData

Posted by GitBox <gi...@apache.org>.

codecov-io commented on pull request #8220:
URL: https://github.com/apache/shardingsphere/pull/8220#issuecomment-730222436


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8220?src=pr&el=h1) Report
   > Merging [#8220](https://codecov.io/gh/apache/shardingsphere/pull/8220?src=pr&el=desc) (97479d6) into [master](https://codecov.io/gh/apache/shardingsphere/commit/739e0b5362c5aaaeaa8f40a921e60aca6626ae9a?el=desc) (739e0b5) will **decrease** coverage by `0.00%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8220/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8220?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8220      +/-   ##
   ============================================
   - Coverage     75.11%   75.11%   -0.01%     
     Complexity      579      579              
   ============================================
     Files          1467     1467              
     Lines         23258    23249       -9     
     Branches       4158     4157       -1     
   ============================================
   - Hits          17471    17464       -7     
   + Misses         4648     4644       -4     
   - Partials       1139     1141       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8220?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...xy/backend/text/admin/BroadcastBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8220/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL0Jyb2FkY2FzdEJhY2tlbmRIYW5kbGVyLmphdmE=) | `63.63% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...re/proxy/backend/text/admin/RDLBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8220/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL1JETEJhY2tlbmRIYW5kbGVyLmphdmE=) | `91.48% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...y/backend/text/admin/ShowTablesBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8220/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL1Nob3dUYWJsZXNCYWNrZW5kSGFuZGxlci5qYXZh) | `22.22% <0.00%> (+5.55%)` | `0.00 <0.00> (ø)` | |
   | [...roxy/backend/text/admin/UnicastBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8220/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL1VuaWNhc3RCYWNrZW5kSGFuZGxlci5qYXZh) | `18.18% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../backend/text/admin/UseDatabaseBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8220/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL1VzZURhdGFiYXNlQmFja2VuZEhhbmRsZXIuamF2YQ==) | `55.55% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../proxy/backend/text/query/QueryBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8220/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L3F1ZXJ5L1F1ZXJ5QmFja2VuZEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...nd/text/sctl/set/ShardingCTLSetBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8220/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L3NjdGwvc2V0L1NoYXJkaW5nQ1RMU2V0QmFja2VuZEhhbmRsZXIuamF2YQ==) | `77.77% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...re/proxy/backend/text/skip/SkipBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8220/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L3NraXAvU2tpcEJhY2tlbmRIYW5kbGVyLmphdmE=) | `50.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...nd/text/transaction/TransactionBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8220/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L3RyYW5zYWN0aW9uL1RyYW5zYWN0aW9uQmFja2VuZEhhbmRsZXIuamF2YQ==) | `53.33% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../query/text/query/MySQLComQueryPacketExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/8220/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvcXVlcnkvdGV4dC9xdWVyeS9NeVNRTENvbVF1ZXJ5UGFja2V0RXhlY3V0b3IuamF2YQ==) | `78.57% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [9 more](https://codecov.io/gh/apache/shardingsphere/pull/8220/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8220?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8220?src=pr&el=footer). Last update [739e0b5...97479d6](https://codecov.io/gh/apache/shardingsphere/pull/8220?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org