You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by ijuma <gi...@git.apache.org> on 2017/06/02 11:38:37 UTC

[GitHub] kafka pull request #3207: MINOR: Fix flaky testHWCheckpointWithFailuresSingl...

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/3207

    MINOR: Fix flaky testHWCheckpointWithFailuresSingleLogSegment

    It was incorrectly passing `oldLeaderOpt` to `waitUntilLeaderIsElectedOrChanged`
    as can be seen by the subsequent assertion. This started failing recently
    because we fixed `waitUntilLeaderIsElectedOrChanged` to handle
    this case correctly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka fix-flaky-testHWCheckpointWithFailuresSingleLogSegment

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3207.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3207
    
----
commit d8ad33168da7d780d6905669edafb959ad461a3c
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-06-02T11:38:24Z

    MINOR: Fix flaky testHWCheckpointWithFailuresSingleLogSegment
    
    It was incorrectly passing `oldLeaderOpt` to `waitUntilLeaderIsElectedOrChanged`
    as can be seen by the subsequent assertion. This started failing recently
    because we fixed `waitUntilLeaderIsElectedOrChanged` to handle
    this case correctly.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---