[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #353: Closes #9800, wait for transaction end to close span.

[GitBox <gi...@apache.org>]

wu-sheng commented on code in PR #353:
URL: https://github.com/apache/skywalking-java/pull/353#discussion_r997850337


##########
apm-sniffer/apm-sdk-plugin/neo4j-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/neo4j/v4x/TransactionRunInterceptor.java:
##########
@@ -61,13 +61,15 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
     @Override
     public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes,
             Object ret) throws Throwable {
-        SessionRequiredInfo requiredInfo = (SessionRequiredInfo) objInst.getSkyWalkingDynamicField();
-        if (requiredInfo == null || requiredInfo.getSpan() == null) {
-            return ret;
-        }
+        return ((CompletionStage<?>) ret).thenApply(resultCursor -> {

Review Comment:
   @guillaume-alvarez I think we face compiling error for the change. This is no `import`ed? Please make compiling passed locally first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org