[GitHub] [incubator-pinot] snleee commented on a change in pull request #4252: pinot_kafka_0.9.0.1 module

[GitBox <gi...@apache.org>]

snleee commented on a change in pull request #4252: pinot_kafka_0.9.0.1 module
URL: https://github.com/apache/incubator-pinot/pull/4252#discussion_r289518361
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -55,6 +55,7 @@
     <module>pinot-azure-filesystem</module>
     <module>pinot-orc</module>
     <module>pinot-parquet</module>
+    <module>pinot-connectors</module>
 
 Review comment:
   Not related to this part but have a question with the main `pom.xml` file. In my understanding, we currently specify `kafka.version = 0.9.0.1` in the main pom.xml file.  After we add the new connector, each connector module will need to pull different kafka version. It will be good if we can start to think about the issue and how we will be managing that.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org