You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:30:38 UTC
[GitHub] [pulsar] srkukarni opened a new pull request #7211: Have metadata tailer use its own thread for processing
srkukarni opened a new pull request #7211:
URL: https://github.com/apache/pulsar/pull/7211
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
Following up on https://github.com/apache/pulsar/pull/7180, this pr does the same thing for function metadata tailer.
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] srkukarni commented on a change in pull request #7211: Have metadata tailer use its own thread for processing
Posted by GitBox <gi...@apache.org>.
srkukarni commented on a change in pull request #7211:
URL: https://github.com/apache/pulsar/pull/7211#discussion_r437650583
##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataTopicTailer.java
##########
@@ -69,28 +106,13 @@ public void processRequest(Message<byte[]> msg) {
serviceRequest = ServiceRequest.parseFrom(msg.getData());
} catch (IOException e) {
log.error("Received bad service request at message {}", msg.getMessageId(), e);
- // TODO: find a better way to handle bad request
- throw new RuntimeException(e);
+ errorNotifier.triggerError(e);
Review comment:
I misunderstood your comments. Yes, that makes sense. Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] srkukarni commented on a change in pull request #7211: Have metadata tailer use its own thread for processing
Posted by GitBox <gi...@apache.org>.
srkukarni commented on a change in pull request #7211:
URL: https://github.com/apache/pulsar/pull/7211#discussion_r437600032
##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataTopicTailer.java
##########
@@ -69,28 +106,13 @@ public void processRequest(Message<byte[]> msg) {
serviceRequest = ServiceRequest.parseFrom(msg.getData());
} catch (IOException e) {
log.error("Received bad service request at message {}", msg.getMessageId(), e);
- // TODO: find a better way to handle bad request
- throw new RuntimeException(e);
+ errorNotifier.triggerError(e);
Review comment:
We would still need to differentiate Interrupted vs others. And if we do encounter some exception isn;'t it better to trigger the errorNotifier and exit perhaps?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #7211: Have metadata tailer use its own thread for processing
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7211:
URL: https://github.com/apache/pulsar/pull/7211#issuecomment-718556906
needs to cherry-pick to 2.6.2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng commented on a change in pull request #7211: Have metadata tailer use its own thread for processing
Posted by GitBox <gi...@apache.org>.
jerrypeng commented on a change in pull request #7211:
URL: https://github.com/apache/pulsar/pull/7211#discussion_r437591612
##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataTopicTailer.java
##########
@@ -19,47 +19,84 @@
package org.apache.pulsar.functions.worker;
import java.io.IOException;
-import java.util.function.Function;
+import lombok.Getter;
import lombok.extern.slf4j.Slf4j;
import org.apache.pulsar.client.api.Message;
-import org.apache.pulsar.client.api.PulsarClientException;
+import org.apache.pulsar.client.api.MessageId;
import org.apache.pulsar.client.api.Reader;
+import org.apache.pulsar.client.api.ReaderBuilder;
+import org.apache.pulsar.client.api.PulsarClientException;
import org.apache.pulsar.functions.proto.Request.ServiceRequest;
@Slf4j
public class FunctionMetaDataTopicTailer
- implements java.util.function.Consumer<Message<byte[]>>, Function<Throwable, Void>, AutoCloseable {
+ implements Runnable, AutoCloseable {
private final FunctionMetaDataManager functionMetaDataManager;
+ @Getter
private final Reader<byte[]> reader;
+ private final Thread readerThread;
+ private volatile boolean running;
+ private ErrorNotifier errorNotifier;
public FunctionMetaDataTopicTailer(FunctionMetaDataManager functionMetaDataManager,
- Reader<byte[]> reader)
+ ReaderBuilder readerBuilder, WorkerConfig workerConfig,
+ ErrorNotifier errorNotifier)
throws PulsarClientException {
this.functionMetaDataManager = functionMetaDataManager;
- this.reader = reader;
+ this.reader = readerBuilder
+ .topic(workerConfig.getFunctionMetadataTopic())
Review comment:
Can you also set the subscription prefix:
```
subscriptionRolePrefix(workerConfig.getWorkerId() + "-function-metadata-manager")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng commented on a change in pull request #7211: Have metadata tailer use its own thread for processing
Posted by GitBox <gi...@apache.org>.
jerrypeng commented on a change in pull request #7211:
URL: https://github.com/apache/pulsar/pull/7211#discussion_r437590589
##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataTopicTailer.java
##########
@@ -69,28 +106,13 @@ public void processRequest(Message<byte[]> msg) {
serviceRequest = ServiceRequest.parseFrom(msg.getData());
} catch (IOException e) {
log.error("Received bad service request at message {}", msg.getMessageId(), e);
- // TODO: find a better way to handle bad request
- throw new RuntimeException(e);
+ errorNotifier.triggerError(e);
Review comment:
Should we just remove the try-catch and let the method throw an exception? Everything is caught in the thread anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng commented on a change in pull request #7211: Have metadata tailer use its own thread for processing
Posted by GitBox <gi...@apache.org>.
jerrypeng commented on a change in pull request #7211:
URL: https://github.com/apache/pulsar/pull/7211#discussion_r437610107
##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataTopicTailer.java
##########
@@ -69,28 +106,13 @@ public void processRequest(Message<byte[]> msg) {
serviceRequest = ServiceRequest.parseFrom(msg.getData());
} catch (IOException e) {
log.error("Received bad service request at message {}", msg.getMessageId(), e);
- // TODO: find a better way to handle bad request
- throw new RuntimeException(e);
+ errorNotifier.triggerError(e);
Review comment:
> We would still need to differentiate Interrupted vs others.
I don't quite follow, the code already differentiates interrupted exceptions vs other exceptions.
Triggering the error in the catch all block in the thread allows us to exit the thread as well and stop further processing of requests. While this doesn't hurt but is cleaner in a sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] srkukarni commented on a change in pull request #7211: Have metadata tailer use its own thread for processing
Posted by GitBox <gi...@apache.org>.
srkukarni commented on a change in pull request #7211:
URL: https://github.com/apache/pulsar/pull/7211#discussion_r437601460
##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataTopicTailer.java
##########
@@ -19,47 +19,84 @@
package org.apache.pulsar.functions.worker;
import java.io.IOException;
-import java.util.function.Function;
+import lombok.Getter;
import lombok.extern.slf4j.Slf4j;
import org.apache.pulsar.client.api.Message;
-import org.apache.pulsar.client.api.PulsarClientException;
+import org.apache.pulsar.client.api.MessageId;
import org.apache.pulsar.client.api.Reader;
+import org.apache.pulsar.client.api.ReaderBuilder;
+import org.apache.pulsar.client.api.PulsarClientException;
import org.apache.pulsar.functions.proto.Request.ServiceRequest;
@Slf4j
public class FunctionMetaDataTopicTailer
- implements java.util.function.Consumer<Message<byte[]>>, Function<Throwable, Void>, AutoCloseable {
+ implements Runnable, AutoCloseable {
private final FunctionMetaDataManager functionMetaDataManager;
+ @Getter
private final Reader<byte[]> reader;
+ private final Thread readerThread;
+ private volatile boolean running;
+ private ErrorNotifier errorNotifier;
public FunctionMetaDataTopicTailer(FunctionMetaDataManager functionMetaDataManager,
- Reader<byte[]> reader)
+ ReaderBuilder readerBuilder, WorkerConfig workerConfig,
+ ErrorNotifier errorNotifier)
throws PulsarClientException {
this.functionMetaDataManager = functionMetaDataManager;
- this.reader = reader;
+ this.reader = readerBuilder
+ .topic(workerConfig.getFunctionMetadataTopic())
Review comment:
Added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] srkukarni merged pull request #7211: Have metadata tailer use its own thread for processing
Posted by GitBox <gi...@apache.org>.
srkukarni merged pull request #7211:
URL: https://github.com/apache/pulsar/pull/7211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org