You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/07/14 04:44:44 UTC

[GitHub] [incubator-dolphinscheduler] gabrywu commented on pull request #2969: add break & default logic for NettyDecoder.decode

gabrywu commented on pull request #2969:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2969#issuecomment-657963137


   hi ,@superScala , unfortunately @qiaozhanwei reverted this PR (https://github.com/apache/incubator-dolphinscheduler/pull/3035) and he gave a useful blog https://www.jianshu.com/p/1f27eaea611d to explain it,  you can get infos from the blog. 
   According to the blog 'break' is no needed, however I till think it's not the best practice to remove break from switch. I suggest that you refactor it using Chain of Responsibility Pattern, waiting for your new PR about this


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org