[bookkeeper] branch master updated: Issue 2445: Builds of Docker tag bookkeeper:latest are failing (#2446)

[zh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

zhaijia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new b004bc3  Issue 2445: Builds of Docker tag bookkeeper:latest are failing (#2446)
b004bc3 is described below

commit b004bc3b1c012ec23381ec400aaa23136268eca7
Author: Enrico Olivelli <eo...@gmail.com>
AuthorDate: Mon Oct 19 14:15:29 2020 +0200

    Issue 2445: Builds of Docker tag bookkeeper:latest are failing (#2446)
    
    Fixes #2445 by not overriding BK_VERSION variable in case of "latest" tag
    
    
    Co-authored-by: Enrico Olivelli <en...@diennea.com>
---
 docker/hooks/build | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/docker/hooks/build b/docker/hooks/build
index 3c479e2..f245083 100755
--- a/docker/hooks/build
+++ b/docker/hooks/build
@@ -1,3 +1,9 @@
 #!/bin/bash
 
-docker build --build-arg BK_VERSION=$DOCKER_TAG -t $IMAGE_NAME .
\ No newline at end of file
+# When we build 'latest' tag we want to not override BK_VERSION variable
+if [[ $DOCKER_TAG = "latest" ]]
+then
+  docker build --build-arg -t $IMAGE_NAME .
+else
+  docker build --build-arg BK_VERSION=$DOCKER_TAG -t $IMAGE_NAME .
+fi