[jira] [Comment Edited] (HBASE-21895) Take more care on the error prone plugin and warnings

["Kevin Risden (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-21895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793899#comment-16793899 ] 

Kevin Risden edited comment on HBASE-21895 at 3/15/19 7:53 PM:
---------------------------------------------------------------

Put up a patch that upgrades errorprone and simplifies a bit (removes custom rule holder since not used currently). Running with "mvn clean verify -DskipTests -PerrorProne" yields at least one error: 
{code:java}
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project hbase-procedure: Compilation failure
[ERROR] /Users/krisden/repos/apache/hbase/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/util/DelayedUtil.java:[63,19] error: [EqualsHashCode] Classes that override equals should also override hashCode.
[ERROR] (see https://errorprone.info/bugpattern/EqualsHashCode)
{code}
I did not fix failures only made sure that errorProne profile ran. I could go through and fix the errors identified just wanted to keep the initial patch simple.


was (Author: risdenk):
Put up a patch that upgrades errorprone and simplifies a bit. Running with "mvn clean verify -DskipTests -PerrorProne" yields at least one error:

 
{code:java}
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project hbase-procedure: Compilation failure
[ERROR] /Users/krisden/repos/apache/hbase/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/util/DelayedUtil.java:[63,19] error: [EqualsHashCode] Classes that override equals should also override hashCode.
[ERROR] (see https://errorprone.info/bugpattern/EqualsHashCode)
{code}
I did not fix failures only made sure that errorProne profile ran.

> Take more care on the error prone plugin and warnings
> -----------------------------------------------------
>
>                 Key: HBASE-21895
>                 URL: https://issues.apache.org/jira/browse/HBASE-21895
>             Project: HBase
>          Issue Type: Umbrella
>            Reporter: Duo Zhang
>            Priority: Major
>         Attachments: HBASE-21895.master.001.patch
>
>
> As shown in HBASE-21890 , the error prone warnings are truly useful.
> But now, the javac warnings section in the pre commit result is messed up, it always reports unrelated warnings. Need to take a look at it.
> And also, we should try out best to clean up the warnings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)