[GitHub] [pinot] swaminathanmanish commented on a diff in pull request #10441: Added optional force param to the table configs update API

["swaminathanmanish (via GitHub)" <gi...@apache.org>]

swaminathanmanish commented on code in PR #10441:
URL: https://github.com/apache/pinot/pull/10441#discussion_r1141518508


##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableConfigsRestletResource.java:
##########
@@ -304,8 +304,10 @@ public ConfigSuccessResponse updateConfig(
       @ApiParam(value = "comma separated list of validation type(s) to skip. supported types: (ALL|TASK|UPSERT)")
       @QueryParam("validationTypesToSkip") @Nullable String typesToSkip,
       @ApiParam(value = "Reload the table if the new schema is backward compatible") @DefaultValue("false")
-      @QueryParam("reload") boolean reload, String tableConfigsStr)
-      throws Exception {
+      @QueryParam("reload") boolean reload,
+      @ApiParam(value = "Force update the table schema") @DefaultValue("false")

Review Comment:
   Could we name this as forceTableSchemaUpdate just to be clear about what we are forcing? Also could we  use this name in the associated functions. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org