You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/07 05:45:08 UTC
[GitHub] [spark] williamhyun opened a new pull request #35745: [SPARK-38430][K8S][DOCS] Add SBT commands to K8s IT readme
williamhyun opened a new pull request #35745:
URL: https://github.com/apache/spark/pull/35745
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] martin-g commented on a change in pull request #35745: [SPARK-38430][K8S][DOCS] Add `SBT` commands to K8s IT README
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #35745:
URL: https://github.com/apache/spark/pull/35745#discussion_r820424635
##########
File path: resource-managers/kubernetes/integration-tests/README.md
##########
@@ -269,3 +269,28 @@ to the wrapper scripts and using the wrapper scripts will simply set these appro
<td></td>
</tr>
</table>
+
+# Running the Kubernetes Integration Tests with SBT
+
+You can use SBT in the same way to build image and run all K8s integration tests except Minikube-only ones.
+
+ build/sbt -Psparkr -Pkubernetes -Pkubernetes-integration-tests \
+ -Dtest.exclude.tags=minikube \
+ -Dspark.kubernetes.test.deployMode=docker-desktop \
+ -Dspark.kubernetes.test.imageTag=2022-03-06 \
+ 'kubernetes-integration-tests/test'
+
+The following is an example to rerun tests with the pre-built image.
Review comment:
Thanks for adding this documentation!
It is not very clear to me what is the difference between `.../test` and `.../runIts` ?
Is it that the first one (re-)builds the image and the second would fail if there is no image ?
##########
File path: resource-managers/kubernetes/integration-tests/README.md
##########
@@ -269,3 +269,28 @@ to the wrapper scripts and using the wrapper scripts will simply set these appro
<td></td>
</tr>
</table>
+
+# Running the Kubernetes Integration Tests with SBT
+
+You can use SBT in the same way to build image and run all K8s integration tests except Minikube-only ones.
+
+ build/sbt -Psparkr -Pkubernetes -Pkubernetes-integration-tests \
Review comment:
Not directly related to this PR but for `./build/mvn` one has to add a profile for Hadoop 2/3 (e.g. `-Phadoop-3`). Otherwise the build fails due to missing AWS classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] martin-g commented on pull request #35745: [SPARK-38430][K8S][DOCS] Add `SBT` commands to K8s IT README
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #35745:
URL: https://github.com/apache/spark/pull/35745#issuecomment-1060334325
Sorry for commenting on closed PR but there was no time for others to review it. It was closed very soon after being opened.
I just tried to say that the new documentation was not clear enough for me (a newbie). I had to read it few times and to consult with the code to understand the difference. I was hoping that it might be improved.
I noticed that the PR is closed when I was finishing the code review - there were no radio buttons to Comment/Approve/Request changes.
I will file tickets for both issues!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35745: [SPARK-38430][K8S][DOCS] Add `SBT` commands to K8s IT README
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35745:
URL: https://github.com/apache/spark/pull/35745#issuecomment-1060940018
It seems that you misunderstand the point. Apache Spark uses post-commit review also actively. That's totally fine and helpful.
My comment is about only your irrelevant comment, https://github.com/apache/spark/pull/35745#discussion_r820468090 . That's no good, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35745: [SPARK-38430][K8S][DOCS] Add `SBT` commands to K8s IT README
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35745:
URL: https://github.com/apache/spark/pull/35745#discussion_r820468983
##########
File path: resource-managers/kubernetes/integration-tests/README.md
##########
@@ -269,3 +269,28 @@ to the wrapper scripts and using the wrapper scripts will simply set these appro
<td></td>
</tr>
</table>
+
+# Running the Kubernetes Integration Tests with SBT
+
+You can use SBT in the same way to build image and run all K8s integration tests except Minikube-only ones.
+
+ build/sbt -Psparkr -Pkubernetes -Pkubernetes-integration-tests \
Review comment:
I'd like to recommend you to file a JIRA officially instead and go for it. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35745: [SPARK-38430][K8S][DOCS] Add `SBT` commands to K8s IT README
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35745:
URL: https://github.com/apache/spark/pull/35745#discussion_r820467059
##########
File path: resource-managers/kubernetes/integration-tests/README.md
##########
@@ -269,3 +269,28 @@ to the wrapper scripts and using the wrapper scripts will simply set these appro
<td></td>
</tr>
</table>
+
+# Running the Kubernetes Integration Tests with SBT
+
+You can use SBT in the same way to build image and run all K8s integration tests except Minikube-only ones.
+
+ build/sbt -Psparkr -Pkubernetes -Pkubernetes-integration-tests \
+ -Dtest.exclude.tags=minikube \
+ -Dspark.kubernetes.test.deployMode=docker-desktop \
+ -Dspark.kubernetes.test.imageTag=2022-03-06 \
+ 'kubernetes-integration-tests/test'
+
+The following is an example to rerun tests with the pre-built image.
Review comment:
To make it sure,
- `../test` is slower and sometimes accidentally overwrite the images.
- `../runIts` is faster and guarantees that there will be no new image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #35745: [SPARK-38430][K8S][DOCS] Add `SBT` commands to K8s IT README
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35745:
URL: https://github.com/apache/spark/pull/35745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #35745: [SPARK-38430][K8S][DOCS] Add `SBT` commands to K8s IT README
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #35745:
URL: https://github.com/apache/spark/pull/35745#issuecomment-1060940018
It seems that you misunderstand the point. Apache Spark uses post-commit review also actively. That's totally fine and helpful.
My comment is about only your irrelevant comment, https://github.com/apache/spark/pull/35745#discussion_r820468090 . That's no good, isn't it?
> Not directly related to this PR but for ./build/mvn one has to add a profile for Hadoop 2/3 (e.g. -Phadoop-3). Otherwise the build fails due to missing AWS classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35745: [SPARK-38430][K8S][DOCS] Add `SBT` commands to K8s IT README
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35745:
URL: https://github.com/apache/spark/pull/35745#discussion_r820465858
##########
File path: resource-managers/kubernetes/integration-tests/README.md
##########
@@ -269,3 +269,28 @@ to the wrapper scripts and using the wrapper scripts will simply set these appro
<td></td>
</tr>
</table>
+
+# Running the Kubernetes Integration Tests with SBT
+
+You can use SBT in the same way to build image and run all K8s integration tests except Minikube-only ones.
+
+ build/sbt -Psparkr -Pkubernetes -Pkubernetes-integration-tests \
+ -Dtest.exclude.tags=minikube \
+ -Dspark.kubernetes.test.deployMode=docker-desktop \
+ -Dspark.kubernetes.test.imageTag=2022-03-06 \
+ 'kubernetes-integration-tests/test'
+
+The following is an example to rerun tests with the pre-built image.
Review comment:
Your understanding is correct and consistent with what @williamhyun described.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35745: [SPARK-38430][K8S][DOCS] Add `SBT` commands to K8s IT README
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35745:
URL: https://github.com/apache/spark/pull/35745#discussion_r820468090
##########
File path: resource-managers/kubernetes/integration-tests/README.md
##########
@@ -269,3 +269,28 @@ to the wrapper scripts and using the wrapper scripts will simply set these appro
<td></td>
</tr>
</table>
+
+# Running the Kubernetes Integration Tests with SBT
+
+You can use SBT in the same way to build image and run all K8s integration tests except Minikube-only ones.
+
+ build/sbt -Psparkr -Pkubernetes -Pkubernetes-integration-tests \
Review comment:
@martin-g . Why do you add your irrelevant comments like that? Actually, it doesn't look like a good way to collaborate because this is open to all the community member and your comments are distracting the the other people from the PR content itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org