[GitHub] [calcite] NobiGo commented on a change in pull request #2710: [CALCITE-4997] Keep approx_count_distinct in RelToSql

[GitBox <gi...@apache.org>]

NobiGo commented on a change in pull request #2710:
URL: https://github.com/apache/calcite/pull/2710#discussion_r802316942



##########
File path: core/src/main/java/org/apache/calcite/sql/SqlDialectFactoryImpl.java
##########
@@ -221,6 +221,8 @@
       return VerticaSqlDialect.DEFAULT;
     case SPARK:
       return SparkSqlDialect.DEFAULT;
+    case SNOWFLAKE:

Review comment:
       Alphabetic order? Looks the SPARK out of position too? 

##########
File path: core/src/main/java/org/apache/calcite/sql/SqlDialect.java
##########
@@ -725,6 +725,11 @@ public boolean supportsAggregateFunction(SqlKind kind) {
     return false;
   }
 
+  /** Returns whether this dialect supports APPROX_COUNT_DISTINCT functions)}. */

Review comment:
       Please remove the redundant brackets.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org