You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by nagix <gi...@git.apache.org> on 2016/02/06 20:05:49 UTC
[GitHub] drill pull request: DRILL-4364: Image Metadata Format Plugin
GitHub user nagix opened a pull request:
https://github.com/apache/drill/pull/367
DRILL-4364: Image Metadata Format Plugin
Initial commit of the Image Metadata Format Plugin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nagix/drill drill-4364
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/367.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #367
----
commit e624536aeb2d5dc6d9bd16fabd8463d2318d7036
Author: Akihiko Kusanagi <ak...@mapr.com>
Date: 2016-02-06T18:55:57Z
DRILL-4364: Image Metadata Format Plugin
- Initial commit of Image Metadata Format Plugin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #367: DRILL-4364: Image Metadata Format Plugin
Posted by nagix <gi...@git.apache.org>.
Github user nagix commented on the issue:
https://github.com/apache/drill/pull/367
@cgivre Yes, I'm still working on this. Since the dependent library (metadata-extractor) has been updated, I need to add some changes according to it. I will push another commit shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #367: DRILL-4364: Image Metadata Format Plugin
Posted by kkhatua <gi...@git.apache.org>.
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/367
@nagix Did you get a chance to rebase this commit?
---
[GitHub] drill issue #367: DRILL-4364: Image Metadata Format Plugin
Posted by cgivre <gi...@git.apache.org>.
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/367
@nagix Are you still working on this? What is the status?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #367: DRILL-4364: Image Metadata Format Plugin
Posted by nagix <gi...@git.apache.org>.
Github user nagix commented on the issue:
https://github.com/apache/drill/pull/367
@cgivre I have made the code up to date. Can you review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #367: DRILL-4364: Image Metadata Format Plugin
Posted by nagix <gi...@git.apache.org>.
Github user nagix commented on the issue:
https://github.com/apache/drill/pull/367
I have updated the dependent library and rebased the code. Now, Image Metadata Format Plugin supports:
- Querying metadata in JPEG, TIFF, PSD, PNG, BMP, GIF, ICO, PCX, WAV, AVI, WebP, MOV, MP4, EPS, ARW (Sony), CRW/CR2 (Canon), NEF (Nikon), ORF (Olympus), RAF (FujiFilm), RW2 (Panasonic), RWL (Leica), SRW (Samsung) and X3F (Foveon) files
- Retrieval of both a human-readable descriptive string and a machine-readable typed value from each tag
- A set of commonly-used fields such as the image width, height and bits per pixels for ease of use
- Querying directories of image files to create your own metadata DB
See also the original JIRA ([DRILL-4364](https://issues.apache.org/jira/browse/DRILL-4364)) and the [reference](https://gist.github.com/nagix/6cac019b7bec698a1b8a234a5268d09d) (still incomplete).
@cgivre, @kkhatua, please can you review this?
---
[GitHub] drill issue #367: DRILL-4364: Image Metadata Format Plugin
Posted by nagix <gi...@git.apache.org>.
Github user nagix commented on the issue:
https://github.com/apache/drill/pull/367
Congratulations, @cgivre! I will check the latest version of the dependent library, and rebase this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4364: Image Metadata Format Plugin
Posted by zfong <gi...@git.apache.org>.
Github user zfong commented on the pull request:
https://github.com/apache/drill/pull/367#issuecomment-200871277
@vkorukanti, @jaltekruse, @adityakishore - since each of you have written format plugins in the past, can one of you help code review this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #367: DRILL-4364: Image Metadata Format Plugin
Posted by cgivre <gi...@git.apache.org>.
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/367
@nagix I just became a committer, and I'd really love to see this incorporated into the latest version of Drill. Are you willing to keep working on this to finish it? If not, I may have some time to complete it.
Thx!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #367: DRILL-4364: Image Metadata Format Plugin
Posted by cgivre <gi...@git.apache.org>.
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/367
@nagix I'd be happy to review it, but I'm not a Drill committer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---