You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2008/08/11 20:12:45 UTC
[jira] Created: (ZOOKEEPER-119) Reserve ".zookeeper" node for
server use.
Reserve ".zookeeper" node for server use.
-----------------------------------------
Key: ZOOKEEPER-119
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-119
Project: Zookeeper
Issue Type: New Feature
Components: server
Reporter: Patrick Hunt
Assignee: Benjamin Reed
The server should not allow clients to create .zookeeper nodes in the node hierarchy. These nodes should be reserved for zk future use, some ideas:
* /.zookeeper/proc
* /.zookeeper/stats
* /.zookeeper/...
* /.../.zookeeper/... (disallow both at root as well as child nodes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-119) Reserve ".zookeeper" node for
server use.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-119:
------------------------------------
Status: Open (was: Patch Available)
cancelling patch to take care of review comments...
> Reserve ".zookeeper" node for server use.
> -----------------------------------------
>
> Key: ZOOKEEPER-119
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-119
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Patrick Hunt
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-119.patch
>
>
> The server should not allow clients to create .zookeeper nodes in the node hierarchy. These nodes should be reserved for zk future use, some ideas:
> * /.zookeeper/proc
> * /.zookeeper/stats
> * /.zookeeper/...
> * /.../.zookeeper/... (disallow both at root as well as child nodes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-119) Reserve ".zookeeper" node for
server use.
Posted by "Savu Andrei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878802#action_12878802 ]
Savu Andrei commented on ZOOKEEPER-119:
---------------------------------------
I believe this JIRA should be closed because ZOOKEEPER-231 already adds "zookeeper" as a reserved node name when creating the hierarchy for quotas.
> Reserve ".zookeeper" node for server use.
> -----------------------------------------
>
> Key: ZOOKEEPER-119
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-119
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Patrick Hunt
> Attachments: ZOOKEEPER-119.patch
>
>
> The server should not allow clients to create .zookeeper nodes in the node hierarchy. These nodes should be reserved for zk future use, some ideas:
> * /.zookeeper/proc
> * /.zookeeper/stats
> * /.zookeeper/...
> * /.../.zookeeper/... (disallow both at root as well as child nodes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-119) Reserve ".zookeeper" node for
server use.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-119:
----------------------------------
Assignee: Jakob Homan (was: Benjamin Reed)
Status: Patch Available (was: Open)
> Reserve ".zookeeper" node for server use.
> -----------------------------------------
>
> Key: ZOOKEEPER-119
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-119
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Patrick Hunt
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-119.patch
>
>
> The server should not allow clients to create .zookeeper nodes in the node hierarchy. These nodes should be reserved for zk future use, some ideas:
> * /.zookeeper/proc
> * /.zookeeper/stats
> * /.zookeeper/...
> * /.../.zookeeper/... (disallow both at root as well as child nodes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-119) Reserve ".zookeeper" node for
server use.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625507#action_12625507 ]
Mahadev konar commented on ZOOKEEPER-119:
-----------------------------------------
review comments for the patch...
the patch just looks for ends with signature which is wrong ...
1) anything like creating a node zookeeper/myname.zookeeper would return true ....
2) i dont htink .zookeeper should be reserved for all the nodes... just the root should be fine
3) I think we should just change .zookeeper to zookeeper
so the only node that zookeeper owns would be
/zookeeper
and that would have all the stats and others. Creating a .zookeeper does not seem right since we dont plan hide it? or do we?
> Reserve ".zookeeper" node for server use.
> -----------------------------------------
>
> Key: ZOOKEEPER-119
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-119
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Patrick Hunt
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-119.patch
>
>
> The server should not allow clients to create .zookeeper nodes in the node hierarchy. These nodes should be reserved for zk future use, some ideas:
> * /.zookeeper/proc
> * /.zookeeper/stats
> * /.zookeeper/...
> * /.../.zookeeper/... (disallow both at root as well as child nodes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-119) Reserve ".zookeeper" node for
server use.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-119:
----------------------------------
Attachment: ZOOKEEPER-119.patch
I went ahead and wrote up a patch to implement this functionality. That way this behavior is inserted into the system as soon as possible and lessens the (already very small) chance that new code will be written that might conflict with it.
The patch:
* Changes the create method to throw a BadArgumentsException when attempting to create a .zookeeper node, either in the root or nested
* Inserts language into the create method javadoc explaining this znode name is reserved for future use by the server
* Adds to the client unit tests to make sure .zookeeper nodes can't be created, but other, similar-sounding nodes, can be.
Hope this is helpful.
> Reserve ".zookeeper" node for server use.
> -----------------------------------------
>
> Key: ZOOKEEPER-119
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-119
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Patrick Hunt
> Assignee: Benjamin Reed
> Attachments: ZOOKEEPER-119.patch
>
>
> The server should not allow clients to create .zookeeper nodes in the node hierarchy. These nodes should be reserved for zk future use, some ideas:
> * /.zookeeper/proc
> * /.zookeeper/stats
> * /.zookeeper/...
> * /.../.zookeeper/... (disallow both at root as well as child nodes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-119) Reserve ".zookeeper" node for
server use.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan reassigned ZOOKEEPER-119:
-------------------------------------
Assignee: (was: Jakob Homan)
> Reserve ".zookeeper" node for server use.
> -----------------------------------------
>
> Key: ZOOKEEPER-119
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-119
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Patrick Hunt
> Attachments: ZOOKEEPER-119.patch
>
>
> The server should not allow clients to create .zookeeper nodes in the node hierarchy. These nodes should be reserved for zk future use, some ideas:
> * /.zookeeper/proc
> * /.zookeeper/stats
> * /.zookeeper/...
> * /.../.zookeeper/... (disallow both at root as well as child nodes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-119) Reserve ".zookeeper" node for
server use.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-119:
----------------------------------
Attachment: (was: ZOOKEEPER-119.patch)
> Reserve ".zookeeper" node for server use.
> -----------------------------------------
>
> Key: ZOOKEEPER-119
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-119
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Patrick Hunt
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-119.patch
>
>
> The server should not allow clients to create .zookeeper nodes in the node hierarchy. These nodes should be reserved for zk future use, some ideas:
> * /.zookeeper/proc
> * /.zookeeper/stats
> * /.zookeeper/...
> * /.../.zookeeper/... (disallow both at root as well as child nodes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-119) Reserve ".zookeeper" node for
server use.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624912#action_12624912 ]
Mahadev konar commented on ZOOKEEPER-119:
-----------------------------------------
yeah, looks like the jira is just for rserving the name :) ....
> Reserve ".zookeeper" node for server use.
> -----------------------------------------
>
> Key: ZOOKEEPER-119
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-119
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Patrick Hunt
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-119.patch
>
>
> The server should not allow clients to create .zookeeper nodes in the node hierarchy. These nodes should be reserved for zk future use, some ideas:
> * /.zookeeper/proc
> * /.zookeeper/stats
> * /.zookeeper/...
> * /.../.zookeeper/... (disallow both at root as well as child nodes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-119) Reserve ".zookeeper" node for
server use.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622010#action_12622010 ]
Jakob Homan commented on ZOOKEEPER-119:
---------------------------------------
Would you also want these to be hidden from/removed from results presented to the getChildren() method, essentially hiding the /.zookeeper from normal client connections? If so, would there then be separate APIs to see it, or would it be completely verboten for client connections?
> Reserve ".zookeeper" node for server use.
> -----------------------------------------
>
> Key: ZOOKEEPER-119
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-119
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Patrick Hunt
> Assignee: Benjamin Reed
>
> The server should not allow clients to create .zookeeper nodes in the node hierarchy. These nodes should be reserved for zk future use, some ideas:
> * /.zookeeper/proc
> * /.zookeeper/stats
> * /.zookeeper/...
> * /.../.zookeeper/... (disallow both at root as well as child nodes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-119) Reserve ".zookeeper" node for
server use.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-119:
----------------------------------
Attachment: ZOOKEEPER-119.patch
D'oh. Slight error in last patch. Ran test twice. Fixed.
> Reserve ".zookeeper" node for server use.
> -----------------------------------------
>
> Key: ZOOKEEPER-119
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-119
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Patrick Hunt
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-119.patch
>
>
> The server should not allow clients to create .zookeeper nodes in the node hierarchy. These nodes should be reserved for zk future use, some ideas:
> * /.zookeeper/proc
> * /.zookeeper/stats
> * /.zookeeper/...
> * /.../.zookeeper/... (disallow both at root as well as child nodes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-119) Reserve ".zookeeper" node for
server use.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622019#action_12622019 ]
Jakob Homan commented on ZOOKEEPER-119:
---------------------------------------
Maybe it would work to create the concept of hidden files, ala Linux? Hide the ones that start with dot by default so that all the getChildren calls don't have to have special code to ignore .zookeeper or others. Then create an overloaded getChildren that returns all the hidden files? Just a thought.
> Reserve ".zookeeper" node for server use.
> -----------------------------------------
>
> Key: ZOOKEEPER-119
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-119
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Patrick Hunt
> Assignee: Benjamin Reed
>
> The server should not allow clients to create .zookeeper nodes in the node hierarchy. These nodes should be reserved for zk future use, some ideas:
> * /.zookeeper/proc
> * /.zookeeper/stats
> * /.zookeeper/...
> * /.../.zookeeper/... (disallow both at root as well as child nodes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-119) Reserve ".zookeeper" node for
server use.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624887#action_12624887 ]
Jakob Homan commented on ZOOKEEPER-119:
---------------------------------------
That sounds good. With this patch I was just trying to implement Patrick's request and reserve the term for future server use.
> Reserve ".zookeeper" node for server use.
> -----------------------------------------
>
> Key: ZOOKEEPER-119
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-119
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Patrick Hunt
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-119.patch
>
>
> The server should not allow clients to create .zookeeper nodes in the node hierarchy. These nodes should be reserved for zk future use, some ideas:
> * /.zookeeper/proc
> * /.zookeeper/stats
> * /.zookeeper/...
> * /.../.zookeeper/... (disallow both at root as well as child nodes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-119) Reserve ".zookeeper" node for
server use.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622013#action_12622013 ]
Patrick Hunt commented on ZOOKEEPER-119:
----------------------------------------
We wouldn't create a new API, a number of benefits in using the existing zk read/write operations.
I don't think we should hide it - .zookeeper/stats for example could be used to get useful information about the system/tree/node. I was thinking about something along the lines of linux proc filesystem.
> Reserve ".zookeeper" node for server use.
> -----------------------------------------
>
> Key: ZOOKEEPER-119
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-119
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Patrick Hunt
> Assignee: Benjamin Reed
>
> The server should not allow clients to create .zookeeper nodes in the node hierarchy. These nodes should be reserved for zk future use, some ideas:
> * /.zookeeper/proc
> * /.zookeeper/stats
> * /.zookeeper/...
> * /.../.zookeeper/... (disallow both at root as well as child nodes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-119) Reserve ".zookeeper" node for
server use.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622018#action_12622018 ]
Patrick Hunt commented on ZOOKEEPER-119:
----------------------------------------
That's a good point though, if we have it in getChildren the results could be confusing... hrm. Hadn't thought through all the issues, at this point just wanted to reserve the node name so that we'd have it available later.
> Reserve ".zookeeper" node for server use.
> -----------------------------------------
>
> Key: ZOOKEEPER-119
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-119
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Patrick Hunt
> Assignee: Benjamin Reed
>
> The server should not allow clients to create .zookeeper nodes in the node hierarchy. These nodes should be reserved for zk future use, some ideas:
> * /.zookeeper/proc
> * /.zookeeper/stats
> * /.zookeeper/...
> * /.../.zookeeper/... (disallow both at root as well as child nodes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-119) Reserve ".zookeeper" node for
server use.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624598#action_12624598 ]
Mahadev konar commented on ZOOKEEPER-119:
-----------------------------------------
i like the idea of having .zookeeper reserved as a proc file system... but we need to be a little more cleaner in implementing this ---
1) I htink .zookeeeper should always exist (as a true node) when a database from scratch is created. The node is read only for the clients.
2) the response that a client gets should be
on creation of .zookeeper return back node already exists
if the client tries and create children of .zookeeper then we throw out an acl issue
and the same with deletion of that node .
> Reserve ".zookeeper" node for server use.
> -----------------------------------------
>
> Key: ZOOKEEPER-119
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-119
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Patrick Hunt
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-119.patch
>
>
> The server should not allow clients to create .zookeeper nodes in the node hierarchy. These nodes should be reserved for zk future use, some ideas:
> * /.zookeeper/proc
> * /.zookeeper/stats
> * /.zookeeper/...
> * /.../.zookeeper/... (disallow both at root as well as child nodes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.