You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2012/05/31 12:00:25 UTC
[jira] [Created] (QPID-4033) add a connection id to the session
dispatcher thread name to avoid name overloading
Robbie Gemmell created QPID-4033:
------------------------------------
Summary: add a connection id to the session dispatcher thread name to avoid name overloading
Key: QPID-4033
URL: https://issues.apache.org/jira/browse/QPID-4033
Project: Qpid
Issue Type: Improvement
Components: Java Client
Reporter: Robbie Gemmell
Priority: Minor
Fix For: 0.17
The session dispatcher thread is currently called "Dispatcher-Channel-<channel number>", this leads to name overloading if there is mroe than one connection present as the channel numbers are not unique on each connection. We should add a connection id number to allow differentiating the names of dispatcher threads on different connections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Resolved] (QPID-4033) [Java client] add a connection id to
the session dispatcher thread name to avoid name overloading
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall resolved QPID-4033.
------------------------------
Resolution: Fixed
Change look good, no comments.
> [Java client] add a connection id to the session dispatcher thread name to avoid name overloading
> -------------------------------------------------------------------------------------------------
>
> Key: QPID-4033
> URL: https://issues.apache.org/jira/browse/QPID-4033
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Priority: Minor
> Fix For: 0.17
>
>
> The session dispatcher thread is currently called "Dispatcher-Channel-<channel number>", this leads to name overloading if there is mroe than one connection present as the channel numbers are not unique on each connection. We should add a connection id number to allow differentiating the names of dispatcher threads on different connections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4033) add a connection id to the session
dispatcher thread name to avoid name overloading
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-4033:
---------------------------------
Status: Ready To Review (was: In Progress)
> add a connection id to the session dispatcher thread name to avoid name overloading
> -----------------------------------------------------------------------------------
>
> Key: QPID-4033
> URL: https://issues.apache.org/jira/browse/QPID-4033
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.17
>
>
> The session dispatcher thread is currently called "Dispatcher-Channel-<channel number>", this leads to name overloading if there is mroe than one connection present as the channel numbers are not unique on each connection. We should add a connection id number to allow differentiating the names of dispatcher threads on different connections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4033) add a connection id to the session
dispatcher thread name to avoid name overloading
Posted by "Rob Godfrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286501#comment-13286501 ]
Rob Godfrey commented on QPID-4033:
-----------------------------------
I guess it really depends where we thinkn this will be most useful... If you have full debug logs then just the numbers are fine... if you are trying to do any sort of post incident analysis based on just an exception stack trace in the log, then having all the information available to you is pretty invaluable. Accept that the length might be an issue though I would think that Disp-127.0.0.1:1234/192.168.1.1:5672[1] would be short enough.
Accept the point about failover
> add a connection id to the session dispatcher thread name to avoid name overloading
> -----------------------------------------------------------------------------------
>
> Key: QPID-4033
> URL: https://issues.apache.org/jira/browse/QPID-4033
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.17
>
>
> The session dispatcher thread is currently called "Dispatcher-Channel-<channel number>", this leads to name overloading if there is mroe than one connection present as the channel numbers are not unique on each connection. We should add a connection id number to allow differentiating the names of dispatcher threads on different connections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4033) add a connection id to the session
dispatcher thread name to avoid name overloading
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288926#comment-13288926 ]
Robbie Gemmell commented on QPID-4033:
--------------------------------------
I have added logging via QPID-4038 to display the connection id number and associated local+remote addresses after each [re]connection.
> add a connection id to the session dispatcher thread name to avoid name overloading
> -----------------------------------------------------------------------------------
>
> Key: QPID-4033
> URL: https://issues.apache.org/jira/browse/QPID-4033
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.17
>
>
> The session dispatcher thread is currently called "Dispatcher-Channel-<channel number>", this leads to name overloading if there is mroe than one connection present as the channel numbers are not unique on each connection. We should add a connection id number to allow differentiating the names of dispatcher threads on different connections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4033) add a connection id to the session
dispatcher thread name to avoid name overloading
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286533#comment-13286533 ]
Robbie Gemmell commented on QPID-4033:
--------------------------------------
I agree on that, but I think thats a general logging problem, not a thread name problem.
> add a connection id to the session dispatcher thread name to avoid name overloading
> -----------------------------------------------------------------------------------
>
> Key: QPID-4033
> URL: https://issues.apache.org/jira/browse/QPID-4033
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.17
>
>
> The session dispatcher thread is currently called "Dispatcher-Channel-<channel number>", this leads to name overloading if there is mroe than one connection present as the channel numbers are not unique on each connection. We should add a connection id number to allow differentiating the names of dispatcher threads on different connections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4033) [Java client] add a connection id to
the session dispatcher thread name to avoid name overloading
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reassigned QPID-4033:
------------------------------------
Assignee: Keith Wall (was: Robbie Gemmell)
Keith, can you review please?
Thanks,
Robbie
> [Java client] add a connection id to the session dispatcher thread name to avoid name overloading
> -------------------------------------------------------------------------------------------------
>
> Key: QPID-4033
> URL: https://issues.apache.org/jira/browse/QPID-4033
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Priority: Minor
> Fix For: 0.17
>
>
> The session dispatcher thread is currently called "Dispatcher-Channel-<channel number>", this leads to name overloading if there is mroe than one connection present as the channel numbers are not unique on each connection. We should add a connection id number to allow differentiating the names of dispatcher threads on different connections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4033) [Java client] add a connection id to
the session dispatcher thread name to avoid name overloading
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-4033:
---------------------------------
Summary: [Java client] add a connection id to the session dispatcher thread name to avoid name overloading (was: add a connection id to the session dispatcher thread name to avoid name overloading)
> [Java client] add a connection id to the session dispatcher thread name to avoid name overloading
> -------------------------------------------------------------------------------------------------
>
> Key: QPID-4033
> URL: https://issues.apache.org/jira/browse/QPID-4033
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.17
>
>
> The session dispatcher thread is currently called "Dispatcher-Channel-<channel number>", this leads to name overloading if there is mroe than one connection present as the channel numbers are not unique on each connection. We should add a connection id number to allow differentiating the names of dispatcher threads on different connections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4033) add a connection id to the session
dispatcher thread name to avoid name overloading
Posted by "Rob Godfrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286465#comment-13286465 ]
Rob Godfrey commented on QPID-4033:
-----------------------------------
By connection-id do you mean the remote IP addr/hostname and port, and local port?
The string "Channel" also seems redundant in the name
> add a connection id to the session dispatcher thread name to avoid name overloading
> -----------------------------------------------------------------------------------
>
> Key: QPID-4033
> URL: https://issues.apache.org/jira/browse/QPID-4033
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Robbie Gemmell
> Priority: Minor
> Fix For: 0.17
>
>
> The session dispatcher thread is currently called "Dispatcher-Channel-<channel number>", this leads to name overloading if there is mroe than one connection present as the channel numbers are not unique on each connection. We should add a connection id number to allow differentiating the names of dispatcher threads on different connections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4033) add a connection id to the session
dispatcher thread name to avoid name overloading
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286518#comment-13286518 ]
Robbie Gemmell commented on QPID-4033:
--------------------------------------
I agree having all the information sounds nice, but it also seems to make things a bit convoluted. I think we would still need to add the 'connection number' identifier I just introduced, because the local port information above is going to change when failover occurs and that would leave it complete pain to track a Dispatcher within a complete log set. I think I still prefer the current simple name (dropping the "Channel").
(Keith also points out that IPv6 addresses would possibly make things entertaining too).
> add a connection id to the session dispatcher thread name to avoid name overloading
> -----------------------------------------------------------------------------------
>
> Key: QPID-4033
> URL: https://issues.apache.org/jira/browse/QPID-4033
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.17
>
>
> The session dispatcher thread is currently called "Dispatcher-Channel-<channel number>", this leads to name overloading if there is mroe than one connection present as the channel numbers are not unique on each connection. We should add a connection id number to allow differentiating the names of dispatcher threads on different connections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4033) add a connection id to the session
dispatcher thread name to avoid name overloading
Posted by "Rob Godfrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286528#comment-13286528 ]
Rob Godfrey commented on QPID-4033:
-----------------------------------
not a huge issue for me... but I find that in general our use of identifiers that can't easily be linked back to anything the user / operational staff can identify is less than ideal.
> add a connection id to the session dispatcher thread name to avoid name overloading
> -----------------------------------------------------------------------------------
>
> Key: QPID-4033
> URL: https://issues.apache.org/jira/browse/QPID-4033
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.17
>
>
> The session dispatcher thread is currently called "Dispatcher-Channel-<channel number>", this leads to name overloading if there is mroe than one connection present as the channel numbers are not unique on each connection. We should add a connection id number to allow differentiating the names of dispatcher threads on different connections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4033) add a connection id to the session
dispatcher thread name to avoid name overloading
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286483#comment-13286483 ]
Robbie Gemmell commented on QPID-4033:
--------------------------------------
No, I just mean something that allows differentiating between the same channel numbers in use on different connections, as opposed to something that really identifies the TCP connection.
Host:port has the potential to be very long, and has additional issues such as changing due to failover occurring etc etc, which would require updating the thread names after the fact. I'm not really looking to get into that, so much as provide a means to separate one connection from another, wherever it may be connected. In this case I just added (missed the commit?) a long value that is incremented with each new connection made, and is logged (at debug) along with the connection URL provided (which includes user, and any host:port combinations provided for failover) to allow at least some path for further identification.
The new names are currently e.g Dispatcher-Channel-1-Conn-1. I guess Channel (and now Conn) is a little redundant I guess, I just left the qualifiers because it makes it easier to distinguish what each number is what without looking up the code. "Dispatcher-1-Conn-1" instead perhaps?
> add a connection id to the session dispatcher thread name to avoid name overloading
> -----------------------------------------------------------------------------------
>
> Key: QPID-4033
> URL: https://issues.apache.org/jira/browse/QPID-4033
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Robbie Gemmell
> Priority: Minor
> Fix For: 0.17
>
>
> The session dispatcher thread is currently called "Dispatcher-Channel-<channel number>", this leads to name overloading if there is mroe than one connection present as the channel numbers are not unique on each connection. We should add a connection id number to allow differentiating the names of dispatcher threads on different connections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4033) add a connection id to the session
dispatcher thread name to avoid name overloading
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reassigned QPID-4033:
------------------------------------
Assignee: Robbie Gemmell
> add a connection id to the session dispatcher thread name to avoid name overloading
> -----------------------------------------------------------------------------------
>
> Key: QPID-4033
> URL: https://issues.apache.org/jira/browse/QPID-4033
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.17
>
>
> The session dispatcher thread is currently called "Dispatcher-Channel-<channel number>", this leads to name overloading if there is mroe than one connection present as the channel numbers are not unique on each connection. We should add a connection id number to allow differentiating the names of dispatcher threads on different connections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Comment Edited] (QPID-4033) add a connection id to the
session dispatcher thread name to avoid name overloading
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286483#comment-13286483 ]
Robbie Gemmell edited comment on QPID-4033 at 5/31/12 11:22 AM:
----------------------------------------------------------------
No, I just mean something that allows differentiating between the same channel numbers in use on different connections, as opposed to something that really identifies the TCP connection.
Host:port has the potential to be very long, and has additional issues such as changing due to failover occurring etc etc, which would require updating the thread names after the fact. I'm not really looking to get into that, so much as provide a means to separate one connection from another, wherever it may be connected. In this case I just added (missed the commit?) a long value that is incremented with each new connection made, and is logged (at debug, could make it info?) along with the connection URL provided (which includes user, and any host:port combinations provided for failover) to allow at least some path for further identification.
The new names are currently e.g Dispatcher-Channel-1-Conn-1. I guess Channel (and now Conn) is a little redundant I guess, I just left the qualifiers because it makes it easier to distinguish what each number is what without looking up the code. "Dispatcher-1-Conn-1" instead perhaps?
was (Author: gemmellr):
No, I just mean something that allows differentiating between the same channel numbers in use on different connections, as opposed to something that really identifies the TCP connection.
Host:port has the potential to be very long, and has additional issues such as changing due to failover occurring etc etc, which would require updating the thread names after the fact. I'm not really looking to get into that, so much as provide a means to separate one connection from another, wherever it may be connected. In this case I just added (missed the commit?) a long value that is incremented with each new connection made, and is logged (at debug) along with the connection URL provided (which includes user, and any host:port combinations provided for failover) to allow at least some path for further identification.
The new names are currently e.g Dispatcher-Channel-1-Conn-1. I guess Channel (and now Conn) is a little redundant I guess, I just left the qualifiers because it makes it easier to distinguish what each number is what without looking up the code. "Dispatcher-1-Conn-1" instead perhaps?
> add a connection id to the session dispatcher thread name to avoid name overloading
> -----------------------------------------------------------------------------------
>
> Key: QPID-4033
> URL: https://issues.apache.org/jira/browse/QPID-4033
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.17
>
>
> The session dispatcher thread is currently called "Dispatcher-Channel-<channel number>", this leads to name overloading if there is mroe than one connection present as the channel numbers are not unique on each connection. We should add a connection id number to allow differentiating the names of dispatcher threads on different connections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Comment Edited] (QPID-4033) add a connection id to the
session dispatcher thread name to avoid name overloading
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286483#comment-13286483 ]
Robbie Gemmell edited comment on QPID-4033 at 5/31/12 11:28 AM:
----------------------------------------------------------------
No, I just mean something that allows differentiating between the same channel numbers in use on different connections, as opposed to something that really identifies the TCP connection.
Host:port has the potential to be very long, and has additional issues such as changing due to failover occurring etc etc, which would require updating the thread names after the fact. I'm not really looking to get into that, so much as provide a means to separate one connection from another, wherever it may be connected. In this case I just added (missed the commit?) a long value that is incremented with each new AMQConnection instance created, and is logged (at debug, could make it info?) along with the connection URL provided (which includes user, and any host:port combinations provided for failover) to allow at least some path for further identification.
The new names are currently e.g Dispatcher-Channel-1-Conn-1. I guess Channel (and now Conn) is a little redundant I guess, I just left the qualifiers because it makes it easier to distinguish what each number is what without looking up the code. "Dispatcher-1-Conn-1" instead perhaps?
was (Author: gemmellr):
No, I just mean something that allows differentiating between the same channel numbers in use on different connections, as opposed to something that really identifies the TCP connection.
Host:port has the potential to be very long, and has additional issues such as changing due to failover occurring etc etc, which would require updating the thread names after the fact. I'm not really looking to get into that, so much as provide a means to separate one connection from another, wherever it may be connected. In this case I just added (missed the commit?) a long value that is incremented with each new connection made, and is logged (at debug, could make it info?) along with the connection URL provided (which includes user, and any host:port combinations provided for failover) to allow at least some path for further identification.
The new names are currently e.g Dispatcher-Channel-1-Conn-1. I guess Channel (and now Conn) is a little redundant I guess, I just left the qualifiers because it makes it easier to distinguish what each number is what without looking up the code. "Dispatcher-1-Conn-1" instead perhaps?
> add a connection id to the session dispatcher thread name to avoid name overloading
> -----------------------------------------------------------------------------------
>
> Key: QPID-4033
> URL: https://issues.apache.org/jira/browse/QPID-4033
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.17
>
>
> The session dispatcher thread is currently called "Dispatcher-Channel-<channel number>", this leads to name overloading if there is mroe than one connection present as the channel numbers are not unique on each connection. We should add a connection id number to allow differentiating the names of dispatcher threads on different connections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org