You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/19 12:26:25 UTC
[GitHub] [doris] Jibing-Li opened a new pull request, #13489: [Fix](multi-catalog)Fix NPE caused by GsonUtils created objects.
Jibing-Li opened a new pull request, #13489:
URL: https://github.com/apache/doris/pull/13489
# Proposed changes
Issue Number: close #xxx
## Problem summary
The `HMSExternalCatalog` fields `dbNameToId` and `idToDb` could be NULL when the HMSExternalCatalog object is created by Gson. Add NPE check before using these two maps.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13489: [Fix](multi-catalog)Fix NPE caused by GsonUtils created objects.
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13489:
URL: https://github.com/apache/doris/pull/13489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13489: [Fix](multi-catalog)Fix NPE caused by GsonUtils created objects.
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13489:
URL: https://github.com/apache/doris/pull/13489#issuecomment-1284628309
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 39.89 seconds
load time: 587 seconds
storage size: 17154768623 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221020061457_clickbench_pr_31568.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13489: [Fix](multi-catalog)Fix NPE caused by GsonUtils created objects.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13489:
URL: https://github.com/apache/doris/pull/13489#issuecomment-1284306572
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #13489: [Fix](multi-catalog)Fix NPE caused by GsonUtils created objects.
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #13489:
URL: https://github.com/apache/doris/pull/13489#issuecomment-1284006816
Please add persist ut for Catalog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13489: [Fix](multi-catalog)Fix NPE caused by GsonUtils created objects.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13489:
URL: https://github.com/apache/doris/pull/13489#issuecomment-1284306635
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org