You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by "dk2k (via GitHub)" <gi...@apache.org> on 2023/03/30 08:52:21 UTC

[GitHub] [camel] dk2k opened a new pull request, #9711: removed unused assignments. Sometimes it allows removing related blocks

dk2k opened a new pull request, #9711:
URL: https://github.com/apache/camel/pull/9711

   # Description
   removed unused assignments. Sometimes it allows removing related blocks of code
   
   # Target
   
   `main` branch
   
   # Tracking
   no dedicated ticket
   
   # Apache Camel coding standards and style
   
   - [x] I checked that each commit in the pull request has a meaningful subject line and body.
   - [x] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus merged pull request #9711: removed unused assignments. Sometimes it allows removing related blocks

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.

davsclaus merged PR #9711:
URL: https://github.com/apache/camel/pull/9711


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] dk2k commented on a diff in pull request #9711: removed unused assignments. Sometimes it allows removing related blocks

Posted by "dk2k (via GitHub)" <gi...@apache.org>.

dk2k commented on code in PR #9711:
URL: https://github.com/apache/camel/pull/9711#discussion_r1153444087


##########
components/camel-sjms/src/test/java/org/apache/camel/component/sjms/support/SjmsConnectionTestSupport.java:
##########
@@ -55,8 +55,6 @@ public void setup() throws Exception {
                 || getConnectionUri().startsWith("vm")) {
             vmTestConnectionFactory = new ActiveMQConnectionFactory(
                     VM_BROKER_CONNECT_STRING);
-        } else {
-            createBroker();

Review Comment:
   Removed the class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9711: removed unused assignments. Sometimes it allows removing related blocks

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #9711:
URL: https://github.com/apache/camel/pull/9711#issuecomment-1490217087

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 12 | 12 | 0 | 12 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] dk2k commented on a diff in pull request #9711: removed unused assignments. Sometimes it allows removing related blocks

Posted by "dk2k (via GitHub)" <gi...@apache.org>.

dk2k commented on code in PR #9711:
URL: https://github.com/apache/camel/pull/9711#discussion_r1153220380


##########
components/camel-sjms/src/test/java/org/apache/camel/component/sjms/support/SjmsConnectionTestSupport.java:
##########
@@ -55,8 +55,6 @@ public void setup() throws Exception {
                 || getConnectionUri().startsWith("vm")) {
             vmTestConnectionFactory = new ActiveMQConnectionFactory(
                     VM_BROKER_CONNECT_STRING);
-        } else {
-            createBroker();

Review Comment:
   Yes. If I remove unused assignment in createBroker(), then I can remove all it's code. Eventually I can delete the method and its call 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on a diff in pull request #9711: removed unused assignments. Sometimes it allows removing related blocks

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.

davsclaus commented on code in PR #9711:
URL: https://github.com/apache/camel/pull/9711#discussion_r1153083703


##########
components/camel-sjms/src/test/java/org/apache/camel/component/sjms/support/SjmsConnectionTestSupport.java:
##########
@@ -55,8 +55,6 @@ public void setup() throws Exception {
                 || getConnectionUri().startsWith("vm")) {
             vmTestConnectionFactory = new ActiveMQConnectionFactory(
                     VM_BROKER_CONNECT_STRING);
-        } else {
-            createBroker();

Review Comment:
   Is this correct ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9711: removed unused assignments. Sometimes it allows removing related blocks

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #9711:
URL: https://github.com/apache/camel/pull/9711#issuecomment-1490643832

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 13 | 13 | 1 | 13 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske commented on a diff in pull request #9711: removed unused assignments. Sometimes it allows removing related blocks

Posted by "orpiske (via GitHub)" <gi...@apache.org>.

orpiske commented on code in PR #9711:
URL: https://github.com/apache/camel/pull/9711#discussion_r1153106414


##########
components/camel-sjms/src/test/java/org/apache/camel/component/sjms/support/SjmsConnectionTestSupport.java:
##########
@@ -55,8 +55,6 @@ public void setup() throws Exception {
                 || getConnectionUri().startsWith("vm")) {
             vmTestConnectionFactory = new ActiveMQConnectionFactory(
                     VM_BROKER_CONNECT_STRING);
-        } else {
-            createBroker();

Review Comment:
   @davsclaus in theory no, but I think this class is unused. 
   
   I think the whole class can be removed. It does not seem to be used anywhere else. Please, can you give it a try @dk2k ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] dk2k commented on a diff in pull request #9711: removed unused assignments. Sometimes it allows removing related blocks

Posted by "dk2k (via GitHub)" <gi...@apache.org>.

dk2k commented on code in PR #9711:
URL: https://github.com/apache/camel/pull/9711#discussion_r1153564011


##########
components/camel-sjms/src/test/java/org/apache/camel/component/sjms/support/SjmsConnectionTestSupport.java:
##########
@@ -55,8 +55,6 @@ public void setup() throws Exception {
                 || getConnectionUri().startsWith("vm")) {
             vmTestConnectionFactory = new ActiveMQConnectionFactory(
                     VM_BROKER_CONNECT_STRING);
-        } else {
-            createBroker();

Review Comment:
   Not sure if the build failed because of my changes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9711: removed unused assignments. Sometimes it allows removing related blocks

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #9711:
URL: https://github.com/apache/camel/pull/9711#issuecomment-1489935874

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :warning: Please note that the changes on this PR may be **tested automatically**. 
   
   If necessary Apache Camel Committers may access logs and test results in the job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske commented on a diff in pull request #9711: removed unused assignments. Sometimes it allows removing related blocks

Posted by "orpiske (via GitHub)" <gi...@apache.org>.

orpiske commented on code in PR #9711:
URL: https://github.com/apache/camel/pull/9711#discussion_r1153571947


##########
components/camel-sjms/src/test/java/org/apache/camel/component/sjms/support/SjmsConnectionTestSupport.java:
##########
@@ -55,8 +55,6 @@ public void setup() throws Exception {
                 || getConnectionUri().startsWith("vm")) {
             vmTestConnectionFactory = new ActiveMQConnectionFactory(
                     VM_BROKER_CONNECT_STRING);
-        } else {
-            createBroker();

Review Comment:
   @dk2k I triggered a new build, but I don't think it's related to your changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org