You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2007/12/07 09:01:48 UTC

[jira] Created: (GSHELL-92) Move the XStream specific bits of the Layout in a helper class

Move the XStream specific bits of the Layout in a helper class
--------------------------------------------------------------

                 Key: GSHELL-92
                 URL: https://issues.apache.org/jira/browse/GSHELL-92
             Project: GShell
          Issue Type: Improvement
      Security Level: public (Regular issues)
    Affects Versions: 1.0-alpha-1
            Reporter: Guillaume Nodet
            Assignee: Jason Dillon
             Fix For: 1.0-alpha-2


The Layout itself does not have any dependency on XStream, so when you're not using an XStream based layout, it's bit weird to have to include this dependecy.  It should be moved to a helper class so that the default layout loader can use it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (GSHELL-92) Move the XStream specific bits of the Layout in a helper class

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Dillon closed GSHELL-92.
------------------------------

    Resolution: Fixed

Added {{LayoutMarshaller}} to hold all the {{marshal}} and {{unmarshall}} related bits.

> Move the XStream specific bits of the Layout in a helper class
> --------------------------------------------------------------
>
>                 Key: GSHELL-92
>                 URL: https://issues.apache.org/jira/browse/GSHELL-92
>             Project: GShell
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.0-alpha-1
>            Reporter: Guillaume Nodet
>            Assignee: Jason Dillon
>             Fix For: 1.0-alpha-2
>
>
> The Layout itself does not have any dependency on XStream, so when you're not using an XStream based layout, it's bit weird to have to include this dependecy.  It should be moved to a helper class so that the default layout loader can use it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GSHELL-92) Move the XStream specific bits of the Layout in a helper class

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GSHELL-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573197#action_12573197 ] 

Guillaume Nodet commented on GSHELL-92:
---------------------------------------

No, annotated objects can be loaded without any problems even if the annotations are not on the classpath.
They are just discarded.   This can lead to difficult problems when diagnosing errors btw.

> Move the XStream specific bits of the Layout in a helper class
> --------------------------------------------------------------
>
>                 Key: GSHELL-92
>                 URL: https://issues.apache.org/jira/browse/GSHELL-92
>             Project: GShell
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.0-alpha-1
>            Reporter: Guillaume Nodet
>            Assignee: Jason Dillon
>             Fix For: 1.0-alpha-2
>
>
> The Layout itself does not have any dependency on XStream, so when you're not using an XStream based layout, it's bit weird to have to include this dependecy.  It should be moved to a helper class so that the default layout loader can use it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GSHELL-92) Move the XStream specific bits of the Layout in a helper class

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GSHELL-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573190#action_12573190 ] 

Jason Dillon commented on GSHELL-92:
------------------------------------

What about the annotations that are used to configure XStream on the other objects?  Having them present requires XStream anyways na?  I agree that the the loading bits should be moved to a {{LayoutLoader}} (or something) class though.

> Move the XStream specific bits of the Layout in a helper class
> --------------------------------------------------------------
>
>                 Key: GSHELL-92
>                 URL: https://issues.apache.org/jira/browse/GSHELL-92
>             Project: GShell
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.0-alpha-1
>            Reporter: Guillaume Nodet
>            Assignee: Jason Dillon
>             Fix For: 1.0-alpha-2
>
>
> The Layout itself does not have any dependency on XStream, so when you're not using an XStream based layout, it's bit weird to have to include this dependecy.  It should be moved to a helper class so that the default layout loader can use it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.