You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/11/17 20:18:25 UTC

[GitHub] [netbeans] mbien opened a new pull request #3278: Build Java cluster on JDK17

mbien opened a new pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278


   Changes required to build the java cluster on JDK17 (15 is the latest version NetBeans can be built with right now). I omitted the other clusters to keep the diff smaller.
   
   This won't make the tests work - that would be a larger issue.
   
   
   note:
   this does not include the Gradle version upgrade required to build on JDK17, since 7.3 it is still in the rc phase.
   to test this, make the following temporary modification:
   
   ```diff
   --- a/extide/gradle/netbeans-gradle-tooling/gradle/wrapper/gradle-wrapper.properties
   +++ b/extide/gradle/netbeans-gradle-tooling/gradle/wrapper/gradle-wrapper.properties
   @@ -19,4 +19,4 @@ distributionBase=GRADLE_USER_HOME
    distributionPath=wrapper/dists
    zipStoreBase=GRADLE_USER_HOME
    zipStorePath=wrapper/dists
   -distributionUrl=../../../external/gradle-6.7-bin.zip
   +distributionUrl=https\://services.gradle.org/distributions/gradle-7.3-rc-3-bin.zip
   ```
   (thanks to @lkishalmi for the tip)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r759647122



##########
File path: harness/apisupport.harness/nbproject/project.properties
##########
@@ -16,7 +16,8 @@
 # under the License.
 
 javac.compilerargs=-Xlint -Xlint:-serial
-javac.source=1.6
+javac.source=1.8
+javac.target=1.8

Review comment:
       You can see the mechanic in the `build.xml`:
   
   https://github.com/apache/netbeans/blob/61795d673369f587d2ae2f50254b442a407b64c0/ide/css.editor/build.xml#L22-L25
   
   The build looks simple, but truth is, that it just inherits its power from:
   
   -  `nbbuild/templates/projectized.xml` (direct)
   -  `nbbuild/templates/common.xml` (transitive)
   -  `nbbuild/default.xml`
   -  `nbbuild/default-properties.xml`
   -  `nbbuild/jdk.xml`
   -  `nbbuild/binaries-default-properties.xml`
   
   The `javac.source` and `javac.target` default values are set by the `basic-init` target in `nbbuild/templates/common.xml`. 
   
   From the default target `build` it is reached via:
   
   - `build`
   - `netbeans
   - `-netbeans`
   - `init`
   - `basic-init`
   
   For using `--release`, this was also tackled by @JaroslavTulach (I think it is in the same PR) - see here:
   
   https://github.com/apache/netbeans/blob/96720b9d39122e514fe21536a831247e5dc17b10/nbbuild/antsrc/org/netbeans/nbbuild/CustomJavac.java#L68-L91
   
   This works only for normal module builds, special cases, where the ant `javac` task is called directly, adjustments need to be made there.
   
   NetBeans build is a complex beast, but it some very nice things in it, at the price that its complex.
   
   For the `javac.target`, yes I think it would be good to not add them, else next time, someone will argue, that the two should be adjusted independently from each other.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r761276680



##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/CustomJavac.java
##########
@@ -66,21 +66,30 @@ public void setIncludes(String includes) {
 
     @Override
     public void execute() throws BuildException {
-        String tgr = getTarget();

Review comment:
       Why is this necessary?  The original implementation moved target to release - why not keep that behavior?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi closed pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
lkishalmi closed pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] neilcsmith-net commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r760360910



##########
File path: extide/o.apache.tools.ant.module/build.xml
##########
@@ -35,7 +35,7 @@
                 <path path="${src-bridge.cp}"/>
             </classpath>
         </depend>
-        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.6" target="1.6" includeantruntime="false">
+        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.8" target="1.8" includeantruntime="false">

Review comment:
       @mbien the Ant compiler task ignores `release` on JDK 8, and ignores `source` and `target` on JDK 9+ if `release` is set.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r760775688



##########
File path: extide/o.apache.tools.ant.module/build.xml
##########
@@ -35,7 +35,7 @@
                 <path path="${src-bridge.cp}"/>
             </classpath>
         </depend>
-        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.6" target="1.6" includeantruntime="false">
+        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.8" target="1.8" includeantruntime="false">

Review comment:
       > set all three to the same value
   
   Looks like Ant's approach is better than Maven's one (fail on JDK8 when release is used) when shielding developers from JDK differences.
   
   > nb-javac throws NPEs when only release is set -> added source and target there too
   
   You can fix the task in `nbbuild/antsrc`...
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#issuecomment-971928268


   @lkishalmi please reconsider, this PR is not about gradle


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#issuecomment-991241757


   #739 fails, but #742 was green. Given, that the test where the timeout occurs is marked @RandomlyFails, a broken tests sounds like a reasonable explanation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#issuecomment-985004058


   Please check the failing unittests - given the error message:
   
   ```
       [junit] INFO: println: /home/travis/build/apache/netbeans/nbbuild/netbeans/harness/common.xml:207: Compile failed; see the compiler error output for details. listener: Hyperlink[file:/home/travis/build/apache/netbeans/nbbuild/netbeans/harness/common.xml:207:-1:-1:-1]
       [junit] Dec 02, 2021 8:37:52 PM org.netbeans.modules.apisupport.project.InputOutputProviderImpl$OW write
       [junit] INFO: BUILD FAILED (total time: 1 second)
   ```
   
   This might indeed a problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#issuecomment-971951637


   My bad, have not checked the list of changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r761304531



##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/CustomJavac.java
##########
@@ -66,21 +66,30 @@ public void setIncludes(String includes) {
 
     @Override
     public void execute() throws BuildException {
-        String tgr = getTarget();

Review comment:
       what is the combination of attributes/JDKs which should be supported but isn't after that change?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#issuecomment-985741118


   Thank you - travis and github actions are happy now. Would you please squash the commits into a single one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#issuecomment-985769879


   done. Maybe @JaroslavTulach would want to take another look since he approved before I changed the ant task.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r761270820



##########
File path: webcommon/libs.jstestdriver/build.xml
##########
@@ -25,7 +25,7 @@
 
     <target name="ext-compile" depends="build-init">
         <mkdir dir="build/extclasses"/>
-        <javac srcdir="extsrc" destdir="build/extclasses" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.6" target="1.8">
+        <javac srcdir="extsrc" destdir="build/extclasses" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" release="8">

Review comment:
       If I read the ant source correctly, this is not correct on JDK 8. You need to set `source`, `target` and `release` to get the desired behavior:
   
   - on JDK 8, `release` will be ignored, as it is invalid for the compiler
   - on JDK 9+, `source` and `target` are ignored




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r761278031



##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/CustomJavac.java
##########
@@ -66,21 +66,30 @@ public void setIncludes(String includes) {
 
     @Override
     public void execute() throws BuildException {
-        String tgr = getTarget();

Review comment:
       it still does that if release isn't set, scroll down.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing merged pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] neilcsmith-net commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r760375911



##########
File path: extide/o.apache.tools.ant.module/build.xml
##########
@@ -35,7 +35,7 @@
                 <path path="${src-bridge.cp}"/>
             </classpath>
         </depend>
-        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.6" target="1.6" includeantruntime="false">
+        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.8" target="1.8" includeantruntime="false">

Review comment:
       @mbien yes, as far as I know. Even an argument that only release is necessary, as the only JDK that's going to ignore it will default to source and target being 8 anyway.  But being specific is probably better!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r760538319



##########
File path: extide/o.apache.tools.ant.module/build.xml
##########
@@ -35,7 +35,7 @@
                 <path path="${src-bridge.cp}"/>
             </classpath>
         </depend>
-        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.6" target="1.6" includeantruntime="false">
+        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.8" target="1.8" includeantruntime="false">

Review comment:
       pushed update:
    - `release` requires the new versioning scheme on modern JDKs -> so i have to use 8 instead of 1.8
    - nb-javac throws NPEs when only release is set -> added source and target there too
    - javac is now using release (without source/target) on all xml files i touched for this PR
    - exception: debugger.jpda.ant can't use release without it causing compiler errors -> kept source/target
    - rebased ontop of latest master, no need to pull gradle changes anymore
    




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r760538319



##########
File path: extide/o.apache.tools.ant.module/build.xml
##########
@@ -35,7 +35,7 @@
                 <path path="${src-bridge.cp}"/>
             </classpath>
         </depend>
-        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.6" target="1.6" includeantruntime="false">
+        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.8" target="1.8" includeantruntime="false">

Review comment:
       pushed update:
    - `release` requires the new versioning scheme on modern JDKs -> so i have to use 8 instead of 1.8
    - nb-javac throws NPEs when only release is set -> added source and target there too
    - javac now uses only release on all xml files i touched for this PR
    - exception: debugger.jpda.ant can't use release without it causing compiler errors -> kept source/target
    - rebased ontop of latest master, no need to pull gradle changes anymore
    




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#issuecomment-991241757


   #739 fails, but #742 was green. Given, that the test where the timeout occurs is marked @RandomlyFails, a broken tests sounds like a reasonable explanation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien edited a comment on pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#issuecomment-985051683


   i see many of those messages on a build which doesn't fail. E.g taken from latest master build:
   https://app.travis-ci.com/github/apache/netbeans/jobs/550425157#L9197-L9199
   
   its difficult to figure out what is failing in a build log full with "build failed" unfortunately
   
   but i _think_ i can reproduce it by running
   `ant -f apisupport/apisupport.ant test` locally
   
   
   i see this locally:
   ```
       [junit] Working directory: /mnt/ram/netbeans/apisupport/apisupport.ant/build/test/unit/work/o.n.m.a.p.q.S/testGetSourceLevel
       [junit] ------------- ---------------- ---------------
       [junit] Testcase: testGetSourceLevel(org.netbeans.modules.apisupport.project.queries.SourceLevelQueryImplTest):	FAILED
       [junit] 1.6 used for an average module expected:<1.[6]> but was:<1.[8]>
       [junit] junit.framework.ComparisonFailure: 1.6 used for an average module expected:<1.[6]> but was:<1.[8]>
       [junit] 	at org.netbeans.modules.apisupport.project.queries.SourceLevelQueryImplTest.testGetSourceLevel(SourceLevelQueryImplTest.java:40)
       [junit] 	at org.netbeans.junit.NbTestCase.access$200(NbTestCase.java:77)
       [junit] 	at org.netbeans.junit.NbTestCase$2.doSomething(NbTestCase.java:476)
       [junit] 	at org.netbeans.junit.NbTestCase$1Guard.run(NbTestCase.java:402)
       [junit] 	at java.lang.Thread.run(Thread.java:748)
   ```
   but travis does not show the stack or any helpful details:
   https://app.travis-ci.com/github/apache/netbeans/jobs/550616807#L10970
   
   I am going to assume that it is the same failure for now (luckily the test has a single method :)).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien edited a comment on pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#issuecomment-985051683


   i see many of those messages on a build which doesn't fail. E.g taken from latest master build:
   https://app.travis-ci.com/github/apache/netbeans/jobs/550425157#L9197-L9199
   
   its difficult to figure out what is failing in a build log full with "build failed" unfortunately
   
   but i _think_ i can reproduce it by running
   `ant -f apisupport/apisupport.ant test` locally
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r761281900



##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/CustomJavac.java
##########
@@ -66,21 +66,30 @@ public void setIncludes(String includes) {
 
     @Override
     public void execute() throws BuildException {
-        String tgr = getTarget();

Review comment:
       https://github.com/apache/netbeans/pull/3278#discussion_r760538319




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r761282643



##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/CustomJavac.java
##########
@@ -66,21 +66,30 @@ public void setIncludes(String includes) {
 
     @Override
     public void execute() throws BuildException {
-        String tgr = getTarget();

Review comment:
       + https://github.com/apache/netbeans/pull/3278#discussion_r760775688




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r761304531



##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/CustomJavac.java
##########
@@ -66,21 +66,30 @@ public void setIncludes(String includes) {
 
     @Override
     public void execute() throws BuildException {
-        String tgr = getTarget();

Review comment:
       what is the combination of attributes/JDKs which should be supported but arent after that change?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#issuecomment-971925944


   I'd close this one in favor of #3322


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r760086210



##########
File path: extide/o.apache.tools.ant.module/build.xml
##########
@@ -35,7 +35,7 @@
                 <path path="${src-bridge.cp}"/>
             </classpath>
         </depend>
-        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.6" target="1.6" includeantruntime="false">
+        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.8" target="1.8" includeantruntime="false">

Review comment:
       Consider adding `release="8"` attribute or using `nb-javac` which is supposed to do that automatically. The same comment applies to all invocations of `<javac />` task, I'd say.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach commented on pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#issuecomment-993228090


   A coincidence, then. Sorry for bothering.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r760086210



##########
File path: extide/o.apache.tools.ant.module/build.xml
##########
@@ -35,7 +35,7 @@
                 <path path="${src-bridge.cp}"/>
             </classpath>
         </depend>
-        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.6" target="1.6" includeantruntime="false">
+        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.8" target="1.8" includeantruntime="false">

Review comment:
       Consider adding `release="8"` attribute or using `nb-javac` which is supposed to do that automatically.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] neilcsmith-net commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r760360910



##########
File path: extide/o.apache.tools.ant.module/build.xml
##########
@@ -35,7 +35,7 @@
                 <path path="${src-bridge.cp}"/>
             </classpath>
         </depend>
-        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.6" target="1.6" includeantruntime="false">
+        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.8" target="1.8" includeantruntime="false">

Review comment:
       @mbien the Ant compiler task ignores `release` on JDK 8.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#issuecomment-980818856


   @matthiasblaesing @neilcsmith-net would be great to get this in. Any reviewer volunteers? easy review
   
   `ant -Dcluster.config=basic` should finally build after this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien edited a comment on pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#issuecomment-985051683


   i see many of those messages on a build which doesn't fail. E.g taken from latest master build:
   https://app.travis-ci.com/github/apache/netbeans/jobs/550425157#L9197-L9199
   
   its difficult to figure out what is failing in a build log full with "build failed" unfortunately
   
   but i _think_ i can reproduce it by running
   `ant -f apisupport/apisupport.ant test` locally
   
   
   i see this locally:
   ```
       [junit] Working directory: /mnt/ram/netbeans/apisupport/apisupport.ant/build/test/unit/work/o.n.m.a.p.q.S/testGetSourceLevel
       [junit] ------------- ---------------- ---------------
       [junit] Testcase: testGetSourceLevel(org.netbeans.modules.apisupport.project.queries.SourceLevelQueryImplTest):	FAILED
       [junit] 1.6 used for an average module expected:<1.[6]> but was:<1.[8]>
       [junit] junit.framework.ComparisonFailure: 1.6 used for an average module expected:<1.[6]> but was:<1.[8]>
       [junit] 	at org.netbeans.modules.apisupport.project.queries.SourceLevelQueryImplTest.testGetSourceLevel(SourceLevelQueryImplTest.java:40)
       [junit] 	at org.netbeans.junit.NbTestCase.access$200(NbTestCase.java:77)
       [junit] 	at org.netbeans.junit.NbTestCase$2.doSomething(NbTestCase.java:476)
       [junit] 	at org.netbeans.junit.NbTestCase$1Guard.run(NbTestCase.java:402)
       [junit] 	at java.lang.Thread.run(Thread.java:748)
   ```
   but travis does not show the stack or any helpful details:
   https://app.travis-ci.com/github/apache/netbeans/jobs/550616807#L10970
   
   I am going to assume that it is the same failure for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r761274133



##########
File path: webcommon/libs.jstestdriver/build.xml
##########
@@ -25,7 +25,7 @@
 
     <target name="ext-compile" depends="build-init">
         <mkdir dir="build/extclasses"/>
-        <javac srcdir="extsrc" destdir="build/extclasses" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.6" target="1.8">
+        <javac srcdir="extsrc" destdir="build/extclasses" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" release="8">

Review comment:
       in theory yes. but this would be only a problem if we would compile on jdk 7 or lower too. 8 would have src and target at 8 by default anyway. Everything else can use release already. @neilcsmith-net pointed this out which i didn't consider either initially.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#issuecomment-990249591


   Ok - travis is happy, lets get this in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r766000609



##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/CustomJavac.java
##########
@@ -66,21 +66,30 @@ public void setIncludes(String includes) {
 
     @Override
     public void execute() throws BuildException {
-        String tgr = getTarget();
-        if (tgr.matches("\\d+")) {
-            tgr = "1." + tgr;
-        }
-        if (!isBootclasspathOptionUsed()) {
-            setRelease(tgr.substring(2));
-        }
-        String src = getSource();
-        if (src.matches("\\d+")) {
-            src = "1." + src;
-        }
-        if (!JavaEnvUtils.isAtLeastJavaVersion(src)) {
-            log("Cannot handle -source " + src + " from this VM; forking " + maybeFork, Project.MSG_WARN);
-            super.setFork(true);
-            super.setExecutable(maybeFork);
+        String release = getRelease();
+        if (release == null || release.isEmpty()) {

Review comment:
       Setting the `release` only when it is not set yet seems OK to me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r766001325



##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/CustomJavac.java
##########
@@ -66,21 +66,30 @@ public void setIncludes(String includes) {
 
     @Override
     public void execute() throws BuildException {
-        String tgr = getTarget();
-        if (tgr.matches("\\d+")) {
-            tgr = "1." + tgr;
-        }
-        if (!isBootclasspathOptionUsed()) {
-            setRelease(tgr.substring(2));
-        }
-        String src = getSource();
-        if (src.matches("\\d+")) {
-            src = "1." + src;
-        }
-        if (!JavaEnvUtils.isAtLeastJavaVersion(src)) {
-            log("Cannot handle -source " + src + " from this VM; forking " + maybeFork, Project.MSG_WARN);
-            super.setFork(true);
-            super.setExecutable(maybeFork);
+        String release = getRelease();
+        if (release == null || release.isEmpty()) {

Review comment:
       thanks for taking a look jaroslav!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r759595309



##########
File path: harness/apisupport.harness/nbproject/project.properties
##########
@@ -16,7 +16,8 @@
 # under the License.
 
 javac.compilerargs=-Xlint -Xlint:-serial
-javac.source=1.6
+javac.source=1.8
+javac.target=1.8

Review comment:
       You don't need to set `javac.target` - @JaroslavTulach ensured this in https://github.com/apache/netbeans/commit/4661771. The build system ensures, that `javac.target` is set to the value of `javac.source` is the former is not set.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r759624899



##########
File path: harness/apisupport.harness/nbproject/project.properties
##########
@@ -16,7 +16,8 @@
 # under the License.
 
 javac.compilerargs=-Xlint -Xlint:-serial
-javac.source=1.6
+javac.source=1.8
+javac.target=1.8

Review comment:
       ok. but it doesn't hurt right? does everything use the same build xml which has this functionality? having source and target at different values can cause trouble if its missed somewhere. (ultimately we should aim to use --release in distant future)
   
   i can remove it if you prefer it gone.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r759653393



##########
File path: harness/apisupport.harness/nbproject/project.properties
##########
@@ -16,7 +16,8 @@
 # under the License.
 
 javac.compilerargs=-Xlint -Xlint:-serial
-javac.source=1.6
+javac.source=1.8
+javac.target=1.8

Review comment:
       thanks for the info. will remove it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r759744426



##########
File path: harness/apisupport.harness/nbproject/project.properties
##########
@@ -16,7 +16,8 @@
 # under the License.
 
 javac.compilerargs=-Xlint -Xlint:-serial
-javac.source=1.6
+javac.source=1.8
+javac.target=1.8

Review comment:
       ok, it builds again on JDK 17.
   
   please note that this branch is fairly old and i don't want to abuse the CI too much just to rebase and push again. So to get the JDK 17 gradle changes do a
   `
   git pull --rebase git@github.com:apache/netbeans.git master`
   
   after you checked out this branch.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r760365171



##########
File path: extide/o.apache.tools.ant.module/build.xml
##########
@@ -35,7 +35,7 @@
                 <path path="${src-bridge.cp}"/>
             </classpath>
         </depend>
-        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.6" target="1.6" includeantruntime="false">
+        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.8" target="1.8" includeantruntime="false">

Review comment:
       @neilcsmith-net interesting! didn't know that. 
   
   plus: "When set and running on JDK 9+ the source and target attributes as well as the bootclasspath will be ignored. Since Ant 1.9.8."
   
   which means we can set all three to the same value? I would be ok with this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r761236717



##########
File path: extide/o.apache.tools.ant.module/build.xml
##########
@@ -35,7 +35,7 @@
                 <path path="${src-bridge.cp}"/>
             </classpath>
         </depend>
-        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.6" target="1.6" includeantruntime="false">
+        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.8" target="1.8" includeantruntime="false">

Review comment:
       added 1d773e0 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#issuecomment-975439704


   @lkishalmi would you like to review this? This would make the java cluster buildable together with the recently merged gradle PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien edited a comment on pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#issuecomment-980818856


   @matthiasblaesing @neilcsmith-net would be great to get this in. Any reviewer volunteers? easy review
   
   `ant -Dcluster.config=basic` should finally build after this (edit: on jdk 17).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r759708026



##########
File path: harness/apisupport.harness/nbproject/project.properties
##########
@@ -16,7 +16,8 @@
 # under the License.
 
 javac.compilerargs=-Xlint -Xlint:-serial
-javac.source=1.6
+javac.source=1.8
+javac.target=1.8

Review comment:
       done, removed `javac.target` from all properties I touched, even if it was there before.
   
   I kept the changes to build xmls since they all had target specified.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r759709372



##########
File path: harness/apisupport.harness/nbproject/project.properties
##########
@@ -16,7 +16,8 @@
 # under the License.
 
 javac.compilerargs=-Xlint -Xlint:-serial
-javac.source=1.6
+javac.source=1.8
+javac.target=1.8

Review comment:
       it doesn't build. looks like i have to add a few targets again.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r760357500



##########
File path: extide/o.apache.tools.ant.module/build.xml
##########
@@ -35,7 +35,7 @@
                 <path path="${src-bridge.cp}"/>
             </classpath>
         </depend>
-        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.6" target="1.6" includeantruntime="false">
+        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.8" target="1.8" includeantruntime="false">

Review comment:
       8 doesn't know `--release`. So i would have to do both, switch to nb-javac and replace both attributes with the release attribute i suppose.
   
   Could we leave this as is until we move to JDK 11+? After that everything will be easier. I am not sure if its worth to put a lot of energy into this, since its only the basic cluster - i expect a lot more changes. It doesn't look like JDK will drop support for source/target any time soon and it does currently allow NB to be built on JDK 17.
   
   Once NB dropped 8 support it would be a fairly simple change. Remove the build support logic Matthias mentioned and switch everything to `javac.release`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r761280322



##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/CustomJavac.java
##########
@@ -66,21 +66,30 @@ public void setIncludes(String includes) {
 
     @Override
     public void execute() throws BuildException {
-        String tgr = getTarget();

Review comment:
       No - why setting release? It is not necessary. The original change ensured, that target is transferred to release, unless the bootclasspath is set.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r761284420



##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/CustomJavac.java
##########
@@ -66,21 +66,30 @@ public void setIncludes(String includes) {
 
     @Override
     public void execute() throws BuildException {
-        String tgr = getTarget();

Review comment:
       Not an answer




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#issuecomment-985051683


   i see many of those messages on a build which doesn't fail. E.g taken from latest master build:
   https://app.travis-ci.com/github/apache/netbeans/jobs/550425157#L9197-L9199
   
   its difficult to figure out what is failing in a build log full with "build failed" unfortunately
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r761128340



##########
File path: extide/o.apache.tools.ant.module/build.xml
##########
@@ -35,7 +35,7 @@
                 <path path="${src-bridge.cp}"/>
             </classpath>
         </depend>
-        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.6" target="1.6" includeantruntime="false">
+        <javac srcdir="src-bridge" destdir="build/bridge-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="1.8" target="1.8" includeantruntime="false">

Review comment:
       > You can fix the task in nbbuild/antsrc...
   
   yes i do want to take a look later. We shouldn't have a configuration divergence between the two javac tasks if its avoidable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r761296033



##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/CustomJavac.java
##########
@@ -66,21 +66,30 @@ public void setIncludes(String includes) {
 
     @Override
     public void execute() throws BuildException {
-        String tgr = getTarget();

Review comment:
       this change ensures that javac and nb-javac do not diverge configuration wise, as mentioned in the linked conversation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists