You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/08/12 00:18:30 UTC
[jira] [Commented] (HIVE-2242) DDL Semantic Analyzer does not pass
partial specification partitions to PreExecute hooks when dropping
partitions
[ https://issues.apache.org/jira/browse/HIVE-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083738#comment-13083738 ]
jiraposter@reviews.apache.org commented on HIVE-2242:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1475/
-----------------------------------------------------------
Review request for hive and Paul Yang.
Summary
-------
Currently, when dropping partitions, the DDL Semantic Analyzer only passes partitions that have a full specification to Pre Execution hooks. It should also include all matches from partial specifications.
E.g., suppose you have a table
create table test_table (a string) partitioned by (p1 string, p2 string);
alter table test_table add partition (p1=1, p2=1);
alter table test_table add partition (p1=1, p2=2);
alter table test_table add partition (p1=2, p2=2);
and you run
alter table test_table drop partition(p1=1);
Pre-execution hooks will not be passed any of the partitions. The expected behavior is for pre-execution hooks to get the WriteEntity's with the partitions "p1=1/p2=1" and "p1=1/p2=2"
This addresses bug HIVE-2242.
https://issues.apache.org/jira/browse/HIVE-2242
Diffs
-----
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1140399
Diff: https://reviews.apache.org/r/1475/diff
Testing
-------
Thanks,
Sohan
> DDL Semantic Analyzer does not pass partial specification partitions to PreExecute hooks when dropping partitions
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-2242
> URL: https://issues.apache.org/jira/browse/HIVE-2242
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Sohan Jain
> Assignee: Sohan Jain
> Attachments: HIVE-2242.1.patch
>
>
> Currently, when dropping partitions, the DDL Semantic Analyzer only passes partitions that have a full specification to Pre Execution hooks. It should also include all matches from partial specifications.
> E.g., suppose you have a table
> {{create table test_table (a string) partitioned by (p1 string, p2 string);}}
> {{alter table test_table add partition (p1=1, p2=1);}}
> {{alter table test_table add partition (p1=1, p2=2);}}
> {{alter table test_table add partition (p1=2, p2=2);}}
> and you run
> {{alter table test_table drop partition(p1=1);}}
> Pre-execution hooks will not be passed any of the partitions. The expected behavior is for pre-execution hooks to get the WriteEntity's with the partitions "p1=1/p2=1" and "p1=1/p2=2"
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira