You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/07 00:57:13 UTC
[GitHub] [apisix] oil-oil opened a new pull request, #6998: docs: replace all apisix-openresty to apisix-base
oil-oil opened a new pull request, #6998:
URL: https://github.com/apache/apisix/pull/6998
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes #6983
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] hf400159 commented on a diff in pull request #6998: docs: replace all apisix-openresty to apisix-base
Posted by GitBox <gi...@apache.org>.
hf400159 commented on code in PR #6998:
URL: https://github.com/apache/apisix/pull/6998#discussion_r867291737
##########
docs/en/latest/admin-api.md:
##########
@@ -564,7 +564,7 @@ The following should be considered when setting the `hash_on` value:
- When set to `vars_combinations`, the `key` is required. The value of the key can be a combination of any of the [Nginx variables](http://nginx.org/en/docs/varindex.html) like `$request_uri$remote_addr`.
- When no value is set for either `hash_on` or `key`, the key defaults to `remote_addr`.
-The features described below requires APISIX to be run on [APISIX-OpenResty](./how-to-build.md#step-6-build-openresty-for-apache-apisix):
+The features described below requires APISIX to be run on [APISIX-Base](./how-to-build.md#step-6-build-openresty-for-apache-apisix):
Review Comment:
There is no `how-to-build.md#step-6-build-openresty-for-apache-apisix` in the latest how-to-build document, we need to change it to another link. We can add step 6 to the FAQ document. Or do we have any other option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6998: docs: replace all apisix-openresty to apisix-base
Posted by GitBox <gi...@apache.org>.
spacewander merged PR #6998:
URL: https://github.com/apache/apisix/pull/6998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a diff in pull request #6998: docs: replace all apisix-openresty to apisix-base
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #6998:
URL: https://github.com/apache/apisix/pull/6998#discussion_r867305320
##########
docs/en/latest/admin-api.md:
##########
@@ -564,7 +564,7 @@ The following should be considered when setting the `hash_on` value:
- When set to `vars_combinations`, the `key` is required. The value of the key can be a combination of any of the [Nginx variables](http://nginx.org/en/docs/varindex.html) like `$request_uri$remote_addr`.
- When no value is set for either `hash_on` or `key`, the key defaults to `remote_addr`.
-The features described below requires APISIX to be run on [APISIX-OpenResty](./how-to-build.md#step-6-build-openresty-for-apache-apisix):
+The features described below requires APISIX to be run on [APISIX-Base](./how-to-build.md#step-6-build-openresty-for-apache-apisix):
Review Comment:
Yes, @oil-oil please check https://apisix.apache.org/docs/apisix/next/how-to-build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #6998: docs: replace all apisix-openresty to apisix-base
Posted by GitBox <gi...@apache.org>.
moonming commented on PR #6998:
URL: https://github.com/apache/apisix/pull/6998#issuecomment-1120126235
That will be great if we can add GitHub repo link for apisix-base
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] oil-oil commented on pull request #6998: docs: replace all apisix-openresty to apisix-base
Posted by GitBox <gi...@apache.org>.
oil-oil commented on PR #6998:
URL: https://github.com/apache/apisix/pull/6998#issuecomment-1120097283
> @oil-oil There are several conflicts need to be fixed.
Okay, I forgot to sync the upstream master branch when I updated 🤓 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #6998: docs: replace all apisix-openresty to apisix-base
Posted by GitBox <gi...@apache.org>.
tokers commented on PR #6998:
URL: https://github.com/apache/apisix/pull/6998#issuecomment-1120096044
@oil-oil There are several conflicts need to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org